Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum powershell version requirements to Contributing.md #2973

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Dec 17, 2023

#skip-changelog

Building the solution on machines with older versions of PowerShell installed results in an error:

The variable '$IsMacOS' cannot be retrieved because it has not been set.

This is because our scripts leverage some automatic variables that are only set in PS Core 6+.

@jamescrosswell jamescrosswell changed the title Add OS detection to build-sentry-native.ps1 script Add minimum powershell version requirements to Contributing.md Dec 18, 2023
@bitsandfoxes bitsandfoxes merged commit f737fc5 into main Dec 18, 2023
4 of 6 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/os-check-powershell branch December 18, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants