Use xcodebuild archive to build sentry-cocoa #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes getsentry#2954 Without the "archive" command xcodebuild will build with code coverage enabled (`-fprofile-instr-generate` is passed to clang) and that links in the compiler profiling runtime. This is evidenced by the `__llvm_profile_runtime` symbol being present in the `Sentry` binary with `nm`. The static initializer will hook up profiling and we get a `default.profraw` file when the app exits. The fix is to use the "archive" command instead, similar to how upstream sentry-cocoa uses it here: https://github.com/getsentry/sentry-cocoa/blob/ddb47781bffd76406f31ab43e66760362585fcd7/Makefile#L82-L83
akoeplinger
requested review from
bitsandfoxes,
jamescrosswell and
Giorgi
as code owners
bruno-garcia
approved these changes
Dec 7, 2023
|
Could add to |
|
Thanks a lot for finding the culprit and fixing the problem!! |
|
Hmm looks like it's is now building for macOS instead of Catalyst :) I'll have another look tomorrow. |
Oh, we build |
|
Figured out the issue, we need to use |
vaind
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2954
Without the "archive" command xcodebuild will build with code coverage enabled (
-fprofile-instr-generateis passed to clang) and that links in the compiler profiling runtime. This is evidenced by the__llvm_profile_runtimesymbol being present in theSentrybinary withnm. The static initializer will hook up profiling and we get adefault.profrawfile when the app exits.The fix is to use the "archive" command instead, similar to how upstream sentry-cocoa uses it here: https://github.com/getsentry/sentry-cocoa/blob/ddb47781bffd76406f31ab43e66760362585fcd7/Makefile#L82-L83