-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use xcodebuild archive to build sentry-cocoa #2960
Conversation
Fixes getsentry#2954 Without the "archive" command xcodebuild will build with code coverage enabled (`-fprofile-instr-generate` is passed to clang) and that links in the compiler profiling runtime. This is evidenced by the `__llvm_profile_runtime` symbol being present in the `Sentry` binary with `nm`. The static initializer will hook up profiling and we get a `default.profraw` file when the app exits. The fix is to use the "archive" command instead, similar to how upstream sentry-cocoa uses it here: https://github.com/getsentry/sentry-cocoa/blob/ddb47781bffd76406f31ab43e66760362585fcd7/Makefile#L82-L83
Could add to
|
Thanks a lot for finding the culprit and fixing the problem!! |
Hmm looks like it's is now building for macOS instead of Catalyst :) I'll have another look tomorrow. |
Oh, we build |
Figured out the issue, we need to use |
Fixes #2954
Without the "archive" command xcodebuild will build with code coverage enabled (
-fprofile-instr-generate
is passed to clang) and that links in the compiler profiling runtime. This is evidenced by the__llvm_profile_runtime
symbol being present in theSentry
binary withnm
. The static initializer will hook up profiling and we get adefault.profraw
file when the app exits.The fix is to use the "archive" command instead, similar to how upstream sentry-cocoa uses it here: https://github.com/getsentry/sentry-cocoa/blob/ddb47781bffd76406f31ab43e66760362585fcd7/Makefile#L82-L83