Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Sentry.Values<T> internal #2771

Merged
merged 2 commits into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ API Changes:
```
- `ISpan` and `ITransaction` have been renamed to `ISpanTracer` and `ITransactionTracer`. You will need to update any references to these interfaces in your code to use the new interface names ([#2731](https://github.com/getsentry/sentry-dotnet/pull/2731))
- Removed obsolete setter from `Sentry.PlatformAbstractions.Runtime.Identifier` ([2764](https://github.com/getsentry/sentry-dotnet/pull/2764))
- `Sentry.Values<T>` is now internal as it is never exposed in the public API ([2771](https://github.com/getsentry/sentry-dotnet/pull/2771))

## Unreleased

Expand Down
3 changes: 1 addition & 2 deletions src/Sentry/SentryValues.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ namespace Sentry;
/// <summary>
/// Helps serialization of Sentry protocol types which include a values property.
/// </summary>
// TODO: consider removing this as we control the serialization now
public sealed class SentryValues<T> : IJsonSerializable
internal sealed class SentryValues<T> : IJsonSerializable
{
/// <summary>
/// The values.
Expand Down
6 changes: 0 additions & 6 deletions test/Sentry.Tests/ApiApprovalTests.Run.Core3_1.verified.txt
Original file line number Diff line number Diff line change
Expand Up @@ -835,12 +835,6 @@ namespace Sentry
public override string ToString() { }
public static Sentry.SentryTraceHeader Parse(string value) { }
}
public sealed class SentryValues<T> : Sentry.IJsonSerializable
{
public SentryValues(System.Collections.Generic.IEnumerable<T>? values) { }
public System.Collections.Generic.IEnumerable<T> Values { get; }
public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }
}
public class Session : Sentry.ISession
{
public Session(string? distinctId, string release, string? environment) { }
Expand Down
6 changes: 0 additions & 6 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt
Original file line number Diff line number Diff line change
Expand Up @@ -836,12 +836,6 @@ namespace Sentry
public override string ToString() { }
public static Sentry.SentryTraceHeader Parse(string value) { }
}
public sealed class SentryValues<T> : Sentry.IJsonSerializable
{
public SentryValues(System.Collections.Generic.IEnumerable<T>? values) { }
public System.Collections.Generic.IEnumerable<T> Values { get; }
public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }
}
public class Session : Sentry.ISession
{
public Session(string? distinctId, string release, string? environment) { }
Expand Down
6 changes: 0 additions & 6 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt
Original file line number Diff line number Diff line change
Expand Up @@ -836,12 +836,6 @@ namespace Sentry
public override string ToString() { }
public static Sentry.SentryTraceHeader Parse(string value) { }
}
public sealed class SentryValues<T> : Sentry.IJsonSerializable
{
public SentryValues(System.Collections.Generic.IEnumerable<T>? values) { }
public System.Collections.Generic.IEnumerable<T> Values { get; }
public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }
}
public class Session : Sentry.ISession
{
public Session(string? distinctId, string release, string? environment) { }
Expand Down
6 changes: 0 additions & 6 deletions test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt
Original file line number Diff line number Diff line change
Expand Up @@ -834,12 +834,6 @@ namespace Sentry
public override string ToString() { }
public static Sentry.SentryTraceHeader Parse(string value) { }
}
public sealed class SentryValues<T> : Sentry.IJsonSerializable
{
public SentryValues(System.Collections.Generic.IEnumerable<T>? values) { }
public System.Collections.Generic.IEnumerable<T> Values { get; }
public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }
}
public class Session : Sentry.ISession
{
public Session(string? distinctId, string release, string? environment) { }
Expand Down
Loading