Removed Scope.Platform as it would never be applied.
#2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bitsandfoxes
approved these changes
Oct 4, 2023
vaind
pushed a commit
that referenced
this pull request
Oct 14, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1590
The Platform property is set in the constructor of
SentryEvent,TransactionandTransactionTracerso it would never be applied by the scope:sentry-dotnet/src/Sentry/Scope.cs
Line 363 in def6231
As such, this has been removed from
Scopeand theIEventLikeinterface (whichScopeimplements). It now exists on both SentryEvent andITransactionData(which is implemented by bothTransactionandTransactionTracer).