-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added AddAttachment
to the Hint
#2585
Conversation
|
@bitsandfoxes do hints get sent to Sentry? I thought they were just there for context prior to capturing an event (so useful in the BeforeSend callback but not afterwards)... |
Yes they do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have good basic tests to ensure attachments can be added to the Hints.
Maybe worth adding a test to the Hub to ensure Hint.Attachments make their way through to Sentry when capturing an event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks for the callout!
Resolves: #2549
Taken from the API we have on the scope to add an attachment. So instead of
we can do