Use 'HttpMessageHandler' instead of 'HttpClientHandler' to support NSUrlSessionHandler on iOS

[AlexSchuetz]

fixing #2502

Breaking change:

• SentryOptions.HttpClientHandlerFactory moved to SentryOptions.HttpMessageHandlerFactory

[bitsandfoxes]

That's a great catch, thanks for contributing!
We'd like to avoid introducing breaking changes outside of mayor releases and the next one is still a bit out.
I'm thinking, could this be added as an additional option and we mark the old one as obsolete?

[AlexSchuetz]

Of course. That's a good idea. I will adjust it shortly. 👍

[jamescrosswell]

Thanks heaps @AlexSchuetz, the commit all looks great!

There are a couple of things that need doing to get things through our CI servers though.

Changelog

Could you add the following to the CHANGELOG.md in the Fixes section?

- Fixes #2502 SentryOptions should use 'HttpMessageHandler' instead of 'HttpClientHandler' to support NSUrlSessionHandler on iOS  ([#2503](https://github.com/getsentry/sentry-dotnet/pull/2503))

Update verify expectations

We're using Verify to make sure that any changes to the API surface area are deliberate. That means when the API does change, we need to update the relevant verified.txt files. The easiest way to create updated versions of those is to run ./build.sh or build.cmd (depending on your development platform) from the repository root folder. So if you're developing on MacOS, for example, you'd run ./build.sh. Once you've done that, I think you should see changes to commit for the following files:

• test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt
• test/Sentry.Tests/ApiApprovalTests.Run.Core3_1.verified.txt
• test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt
• test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt

You can add those to a new commit with a description like "updated verify files" or something like that and push.

Note: You can ignore any errors the build shows relating to profiling... that's a long story and unrelated to this PR.

Failed Checks

There are a couple of other checks that are failing. I'm not actually sure what's going on there. @bitsandfoxes do you have any context for that?

[AlexSchuetz]

I did the required commit and also had a look at the error. NSUrlSessionHandler does not support a proxy, but I want to include the code for setting it anyway, because if it ever does noone will remember adjusting it here.
Thus I implemented it and placed it inside of a try-catch. So nothing should go wrong. I now adjusted my implementation and check NSUrlSessionHandler.SupportsProxy. Hopefully this works.

[AlexSchuetz]

I investigated a bit more. It is a code analysis error. Since NSUrlSessionHandler.Proxy is not supported.
I added a pragma for this one line to disable this issue, since I want to support it as soon as NSUrlSesseionHandler does.

If you think I should remove the code in question and just print out that a proxy for NSUrlSessionHandler is not supported, that would be fine as well. I don't know if the Proxy-property will ever be implemented. I think iOS and MAC require a proxy to be defined elsewhere.

[bruno-garcia]

Left some minor suggestions but generally lgtm

[AlexSchuetz]

@bruno-garcia I followed your suggestions. Am I supposed to resolve those conversations now?

[bitsandfoxes]

Am I supposed to resolve those conversations now?

Yes. Everything that has been addressed can be marked as resolved.

[bitsandfoxes]

This looks good to me! Thanks again for contributing!

[AlexSchuetz]

@bitsandfoxes @bruno-garcia You are welcome. Thank's for your support and review.