Allow setting the active span on the scope #2364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the
GetSpan
method on theScope
class has been obsoleted, and replaced with aSpan
property that has both a getter and a setter.Previous usage:
New usage:
That's the boring part. The new interesting part is that you can now set the span if desired. This can be used to pin an active span as the root span before starting complex tasks such as doing work in parallel. This allows each subsequent child span to attach to the root, rather than to each other.
For example:
Or asynchronously:
Or asynchronously with tasks:
Resolves #1845
Resolves #1679