Workaround VS Pair to Mac issue #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround xamarin/xamarin-macios#16001 by ensuring that the
net6.0-iostarget ofSentry.Bindings.Cocoadoes not contain a zipped resources file.We can do this by building the Sentry Cocoa SDK separately for iOS than for MacCatalyst. Only the MacCatalyst build contains symlinks, so the iOS resources will be copied into the package directly instead of being zipped. Nice side effect of this is the
Sentry.Bindings.Cocoanuget package reduces in size from 20MB to 10.5MB, because each target only has the native files it needs, rather than the whole xcframework.Now that the resources aren't being zipped, we also need to strip out the Cocoa header files. Otherwise, the build gives an error when packaging due to long file paths. (We don't need the header files in the nuget package anyway.)
Fixes #2037 - Tested with VS on Windows with a pre-release package.
Also bumped the Cocoa SDK from 7.31.4 to 7.31.5. (We'll do 8.x with #2148)