Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DI for custom transaction processors #1993

Merged
merged 3 commits into from
Oct 16, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

Follow up from #1979 and #1862

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) October 15, 2022 23:51
{
e.Data[Mechanism.HandledKey] = false;
e.Data[Mechanism.MechanismKey] = mechanism;

var evt = new SentryEvent(e, eventId: eventId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW i prefer eventId

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, but there was a yellow warning due to hiding the outer variable with the same name.

@mattjohnsonpint mattjohnsonpint merged commit 9207d7b into main Oct 16, 2022
@mattjohnsonpint mattjohnsonpint deleted the scoped-transaction-processors branch October 16, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants