Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap GetFromRuntimeInformation() in try-catch #1554

Merged
merged 2 commits into from
Mar 26, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Mar 24, 2022

This is a workaround for Unity 2020+ issue - throws on accessing RuntimeInformation.FrameworkDescription - reported to Unity

#skip-changelog

@SimonCropp SimonCropp added the Bug Something isn't working label Mar 24, 2022
@SimonCropp SimonCropp self-assigned this Mar 24, 2022
@vaind vaind force-pushed the chore/runtime-info-trycatch branch from 7fc63e6 to 8d76fe1 Compare March 25, 2022 10:35
@codecov-commenter
Copy link

Codecov Report

Merging #1554 (8d76fe1) into main (e3ca414) will increase coverage by 1.57%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1554      +/-   ##
==========================================
+ Coverage   82.78%   84.35%   +1.57%     
==========================================
  Files         219      219              
  Lines        7419     7423       +4     
  Branches     1417     1417              
==========================================
+ Hits         6142     6262     +120     
+ Misses        852      735     -117     
- Partials      425      426       +1     
Impacted Files Coverage Δ
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 56.45% <50.00%> (+3.00%) ⬆️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
src/Sentry/Internal/BackgroundWorker.cs 93.47% <0.00%> (+1.44%) ⬆️
...ce/Internals/DiagnosticSource/SentrySqlListener.cs 83.12% <0.00%> (+2.50%) ⬆️
src/Sentry/Exceptions/SentryStackFrame.cs 78.02% <0.00%> (+3.29%) ⬆️
src/Sentry/Internal/SdkComposer.cs 74.46% <0.00%> (+4.25%) ⬆️
...ntry/Integrations/NetFxInstallationsIntegration.cs 57.14% <0.00%> (+28.57%) ⬆️
...als/DiagnosticSource/SentryDiagnosticSubscriber.cs 95.45% <0.00%> (+36.36%) ⬆️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 62.50% <0.00%> (+37.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ca414...8d76fe1. Read the comment docs.

@SimonCropp SimonCropp merged commit 1cdde37 into main Mar 26, 2022
@SimonCropp SimonCropp deleted the chore/runtime-info-trycatch branch March 26, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants