Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnobservedTaskException is unhandled #1447

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

bruno-garcia
Copy link
Member

No description provided.

@bruno-garcia
Copy link
Member Author

just changed it through GitHub, still need a test to avoid regression

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #1447 (bcf8edc) into main (782bdfd) will decrease coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
- Coverage   83.41%   82.79%   -0.63%     
==========================================
  Files         219      219              
  Lines        7370     7371       +1     
  Branches     1411     1411              
==========================================
- Hits         6148     6103      -45     
- Misses        790      840      +50     
+ Partials      432      428       -4     
Impacted Files Coverage Δ
...grations/TaskUnobservedTaskExceptionIntegration.cs 92.30% <100.00%> (+0.64%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-50.00%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-18.19%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-15.50%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-12.50%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Exceptions/SentryStackFrame.cs 80.48% <0.00%> (-1.22%) ⬇️
src/Sentry/Exceptions/Mechanism.cs 85.29% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782bdfd...bcf8edc. Read the comment docs.

@bruno-garcia bruno-garcia enabled auto-merge (squash) February 2, 2022 00:26
@bruno-garcia bruno-garcia merged commit 3827b35 into main Feb 2, 2022
@bruno-garcia bruno-garcia deleted the fix/UnobservedTaskException-unhandled branch February 2, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants