-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added overloads to Capture methods to replace WithScope #1412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but we can't remove the public API just yet.
And we'll need to run the Verify snapshot to get the new API diff
Codecov Report
@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
+ Coverage 82.78% 84.10% +1.31%
==========================================
Files 219 219
Lines 7350 7374 +24
Branches 1409 1411 +2
==========================================
+ Hits 6085 6202 +117
+ Misses 838 735 -103
- Partials 427 437 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, otherwise LGTM
Aims to solve: #675