-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Avoid serializing dangerous types. #1134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1134 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 200 201 +1
Lines 6617 6629 +12
Branches 1465 1468 +3
=======================================
+ Hits 5346 5356 +10
- Misses 800 801 +1
- Partials 471 472 +1
Continue to review full report at Codecov.
|
Tyrrrz
reviewed
Jul 21, 2021
Tyrrrz
reviewed
Jul 22, 2021
lucas-zimerman
commented
Jul 23, 2021
bruno-garcia
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will stop the drop of events and transactions if their content contains a dangerous class type and junk to be serialized.
Changes
System.Reflection
(avoiding types that leads to infinite loops by self including themselves).Close #1108, partially close #962.
EIDT: Might also close #950 because it's one of the type of issues that got fixed by removing references to System.Reflection (I wasn't able to reproduce it with TimeZone)