Avoid Unhandled Exception on .NET 461 if the Registry Access threw an exception.

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- Avoid Unhandled Exception on .NET 461 if the Registry Access threw an exception([#1101](https://github.com/getsentry/sentry-dotnet/pull/1101))
 - `IHub.ResumeSession()`: don't start a new session if pause wasn't called or if there is no active session ([#1089](https://github.com/getsentry/sentry-dotnet/pull/1089))
 - Fixed incorrect order when getting the last active span ([#1094](https://github.com/getsentry/sentry-dotnet/pull/1094))
 - Fix logger call in BackgroundWorker that caused a formatting exception in runtime ([#1092](https://github.com/getsentry/sentry-dotnet/pull/1092))

samples/Sentry.Samples.Console.Basic/Sentry.Samples.Console.Basic.csproj

@@ -4,11 +4,12 @@
     <OutputType>Exe</OutputType>
     <!--Version is detected by default as the application release and sent to sentry-->
     <Version>9.8.7</Version>
-    <TargetFramework>net5.0</TargetFramework>
+    <TargetFrameworks>net5.0;netcoreapp2.1;net461</TargetFrameworks>
+    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
   </PropertyGroup>
 
   <ItemGroup>
     <ProjectReference Include="../../src/Sentry/Sentry.csproj" />
   </ItemGroup>
-
+  
 </Project>

src/Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs

@@ -1,6 +1,7 @@
 #if NET461
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Microsoft.Win32;
 
 namespace Sentry.PlatformAbstractions
@@ -10,6 +11,8 @@ namespace Sentry.PlatformAbstractions
     /// </summary>
     public static partial class FrameworkInfo
     {
+        internal const string NetFxNdpRegistryKey = @"SOFTWARE\Microsoft\NET Framework Setup\NDP\";
+        internal const string NetFxNdpFullRegistryKey = @"SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full\";
         /// <summary>
         /// Get the latest Framework installation for the specified CLR
         /// </summary>
@@ -20,7 +23,7 @@ public static partial class FrameworkInfo
         /// CLR 4 => .NET 4.0, 4.5.x, 4.6.x, 4.7.x
         /// </remarks>
         /// <param name="clrVersion">The CLR version: 1, 2 or 4</param>
-        /// <returns>The framework installation or null if none is found.</returns>
+        /// <returns>The framework installation or null if none is found, used for fine-tuning the Latest info.</returns>
         public static FrameworkInstallation? GetLatest(int clrVersion)
         {
             // CLR versions
@@ -85,8 +88,19 @@ public static partial class FrameworkInfo
         /// <returns>Enumeration of installations</returns>
         public static IEnumerable<FrameworkInstallation> GetInstallations()
         {
-            using var ndpKey = RegistryKey.OpenRemoteBaseKey(RegistryHive.LocalMachine, string.Empty)
-                .OpenSubKey(@"SOFTWARE\Microsoft\NET Framework Setup\NDP\");
+            try
+            {
+                using var ndpKey = Registry.LocalMachine.OpenSubKey(NetFxNdpRegistryKey, false);
+                return GetInstallationsFromRegistryKey(ndpKey).ToArray();
+            }
+            catch
+            {
+                return null;
+            }
+        }
+
+        internal static IEnumerable<FrameworkInstallation> GetInstallationsFromRegistryKey(RegistryKey? ndpKey)
+        {
             if (ndpKey == null)
             {
                 yield break;
@@ -160,16 +174,24 @@ private static FrameworkInstallation GetFromV4(RegistryKey subKey, string subKey
                 },
                 Version = version,
                 ServicePack = subKey.GetInt("SP"),
-                Release = hasRelease ? release : null as int?
+                Release = hasRelease ? release : null
             };
         }
 
         // https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed#to-find-net-framework-versions-by-querying-the-registry-in-code-net-framework-45-and-later
         internal static int? Get45PlusLatestInstallationFromRegistry()
         {
-            using var ndpKey = RegistryKey.OpenBaseKey(RegistryHive.LocalMachine, RegistryView.Registry32)
-                .OpenSubKey(@"SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full\");
-            return ndpKey?.GetInt("Release");
+            {
+                try
+                {
+                    using var ndpKey = Registry.LocalMachine.OpenSubKey(NetFxNdpFullRegistryKey, false);
+                    return ndpKey?.GetInt("Release");
+                }
+                catch
+                {
+                    return null;
+                }
+            }
         }
 
         internal static Version GetNetFxVersionFromRelease(int release)

src/Sentry/PlatformAbstractions/NetFxInstallationsEventProcessor.cs

@@ -3,6 +3,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
+using Microsoft.Win32;
 using Sentry.Extensibility;
 
 namespace Sentry.PlatformAbstractions
@@ -23,7 +24,8 @@ internal class NetFxInstallationsEventProcessor : ISentryEventProcessor
         internal static Dictionary<string, string> GetInstallationsDictionary()
         {
             var versionsDictionary = new Dictionary<string, string>();
-            var installations = FrameworkInfo.GetInstallations().ToArray();
+            using var registryKey = Registry.LocalMachine.OpenSubKey(FrameworkInfo.NetFxNdpRegistryKey, false);
+            var installations = FrameworkInfo.GetInstallationsFromRegistryKey(registryKey).ToArray();
             foreach (var profile in installations.Select(p => p.Profile).Distinct())
             {
                 versionsDictionary.Add($"{NetFxInstallationsKey} {profile}",

src/Sentry/PlatformAbstractions/RuntimeInfo.cs

@@ -60,14 +60,14 @@ internal static void SetNetFxReleaseAndVersion(Runtime runtime)
                 var latest = FrameworkInfo.GetLatest(Environment.Version.Major);
 
                 runtime.FrameworkInstallation = latest;
-                if (latest.Version?.Major < 4)
+                if (latest?.Version?.Major < 4)
                 {
                     // prior to 4, user-friendly versions are always 2 digit: 1.0, 1.1, 2.0, 3.0, 3.5
                     runtime.Version = latest.ServicePack == null
                         ? $"{latest.Version.Major}.{latest.Version.Minor}"
                         : $"{latest.Version.Major}.{latest.Version.Minor} SP {latest.ServicePack}";
                 }
-                else
+                else if (latest != null)
                 {
                     runtime.Version = latest.Version?.ToString();
                 }