Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto session tracking #1068

Merged
merged 4 commits into from
Jun 19, 2021
Merged

Add auto session tracking #1068

merged 4 commits into from
Jun 19, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jun 18, 2021

Related to #1054
Implemented through ISdkIntegration.

Tests omitted.

Note the issue says:

Add an option: EnableAutoSessionTracking with default false until our next major, where we'll flip the default to true.

Should we do that? I added it as true by default because I thought that was the consensus.

@Tyrrrz Tyrrrz added Feature New feature or request Product: Release Health labels Jun 18, 2021
@Tyrrrz Tyrrrz requested a review from bruno-garcia as a code owner June 18, 2021 19:42
@bruno-garcia
Copy link
Member

Add an option: EnableAutoSessionTracking with default false until our next major, where we'll flip the default to true.

Should we do that? I added it as true by default because I thought that was the consensus.

I thought it would be best if we only started sending session data on a major release (as we did for Android, JavaScript, iOS) and until then had it as a opt-in feature.

On a server application we'd definitely want that turned off so we need to add to the ASP.NET and ASP.NET Core packages as false.

We can always flip the flag later on, lets start with it as false.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than we should default to false and again on aspnet and aspnetcore default to false again because we'll flip this to true on the core next major.

On the comment we should say: Default is false but will be changed to true on the next major release.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Jun 18, 2021

Updated. Not sure why the tests are failing (seems unrelated but who knows). I don't really have time to debug it today, but I will look into it next week (unless you want to poke at it yourself).

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #1068 (12778f8) into main (f20b3f0) will decrease coverage by 0.04%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
- Coverage   80.69%   80.64%   -0.05%     
==========================================
  Files         194      195       +1     
  Lines        6284     6294      +10     
  Branches     1397     1399       +2     
==========================================
+ Hits         5071     5076       +5     
- Misses        757      760       +3     
- Partials      456      458       +2     
Impacted Files Coverage Δ
...try/Integrations/AutoSessionTrackingIntegration.cs 28.57% <28.57%> (ø)
src/Sentry/SentryOptions.cs 91.09% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20b3f0...12778f8. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 022fd69 into main Jun 19, 2021
@bruno-garcia bruno-garcia deleted the auto-session branch June 19, 2021 16:27
@bruno-garcia
Copy link
Member

CI passed. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants