-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting CaptureFailedRequests only affects the .NET layer #2744
Labels
Comments
Hi @rodolfoBee, thanks for creating an issue. That all makes sense. It might take us a little while to get around to this as we're currently preparing things for the .NET 8 release but we'll definitely look into this. |
carmichaelalonso
added a commit
to carmichaelalonso/sentry-dotnet
that referenced
this issue
Nov 13, 2023
Fixes getsentry#2744 Setting either `CaptureFailedRequests` or `FailedRequestStatusCodes` previously only affected the .NET layer and was not passed to sentry-cocoa. In production, this meant that failed requests were being tracked despite the setting being set to false.
Hi, I created a PR to fix this. We initially reported the issue to @rodolfoBee via Sentry support, but noticed today that it was a simple fix. PR: #2826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Package
Sentry.Maui
.NET Flavor
.NET
.NET Version
7.0.0
OS
iOS
SDK Version
3.40.1
Self-Hosted Sentry Version
No response
Steps to Reproduce
Create a simple app that has HTTP errors (400, 404...) on the ios layer
set
options.CaptureFailedRequests = false
in the .NET SDK init.Expected Result
The expectation when setting CaptureFailedRequests = false on the .NET sdk is that this option will be passed on the native SDKs, thus the cocoa SDK will also not send HTTP failed requests events.
In other words, it will automatically set
enableCaptureFailedRequests = false
in the underlaying cocoa SDKActual Result
The option is not propagated to cocoa SDK and HTTP failed requests that happen on the ios layer are sent to Sentry.
The text was updated successfully, but these errors were encountered: