Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test to proguard mapping upload #2575

Closed
bruno-garcia opened this issue Aug 22, 2023 · 2 comments · Fixed by #2947
Closed

Add integration test to proguard mapping upload #2575

bruno-garcia opened this issue Aug 22, 2023 · 2 comments · Fixed by #2947
Assignees
Labels
Bug Something isn't working

Comments

@bruno-garcia
Copy link
Member

We got integration test for sentry-cli upload commands here: #2191

We'll need to change:

https://github.com/getsentry/github-workflows/blob/fe18d6efa7d9802333d50e8e4567afbdc99844cc/sentry-cli/integration-test/action.psm1#L14

To include the proguard mapping command

Then change the test file:

It "uploads symbols and sources for a MAUI Android app build" {
$result = DotnetBuild 'Sentry.Samples.Maui' $True $True 'net7.0-android'
$result.ScriptOutput | Should -Contain 'Build succeeded.'
$result.HasErrors() | Should -BeFalse
$result.UploadedDebugFiles() | Sort-Object -Unique | Should -Be @(
'Sentry.Android.AssemblyReader.pdb',
'Sentry.Bindings.Android.pdb',
'Sentry.Extensions.Logging.pdb',
'Sentry.Maui.pdb',
'Sentry.pdb',
'Sentry.Samples.Maui.pdb',
'Sentry.Samples.Maui.src.zip'
)

To include the Sample Android app, which is configured to upload.

This should avoid regressions.

@vaind
Copy link
Collaborator

vaind commented Oct 19, 2023

Also, from what I can tell the proguard mapping is broken at the moment:

  1. this should be sentry-proguard.cfg: https://github.com/getsentry/sentry-dotnet/pull/2450/files#diff-a00f24179d4fb2ec1e497e77c12422251f15c3c2e62c9c5155eff83f57bc606fR3
  2. the mapping should only be uploaded when Sentry CLI is configured correctly, i.e. check '$(SentryCLI)' != '' in target's condition

@vaind vaind added the Bug Something isn't working label Oct 19, 2023
@bruno-garcia
Copy link
Member Author

Support to upload mapping added here:

Before that we added some built-in rules that must be available at build time:

An attempt to fix this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants