Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload proguard mapping #2574

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix: upload proguard mapping #2574

merged 2 commits into from
Aug 22, 2023

Conversation

bruno-garcia
Copy link
Member

  1. fix: proguard upload command invocation
  2. fix: allow enable only proguard command (without enabling debug file upload)
  3. Check command exit code and print message if failed
  4. enabled R8 in our sample

@bruno-garcia
Copy link
Member Author

I opened a follow up ticket for integration testing this: #2575
Maybe @vaind can help?

I tried running the script locally to add the test, but it fails to run completely with

Line |
  12 |  BeforeAll {
     |  ~~~~~~~~~
     | The term 'BeforeAll' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Not sure what's wrong on my local dev right now

@bruno-garcia bruno-garcia merged commit 87d2c11 into main Aug 22, 2023
15 checks passed
@bruno-garcia bruno-garcia deleted the fix/upload-proguard branch August 22, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants