logs

getsentry · Sep 25, 2024 · 5aba1d2 · 5aba1d2
1 parent aa39e58
commit 5aba1d2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/src/Sentry/GlobalSessionManager.cs b/src/Sentry/GlobalSessionManager.cs
@@ -55,9 +55,18 @@ private void PersistSession(SessionUpdate update, DateTimeOffset? pauseTimestamp
         {
             _options.LogDebug("Creating persistence directory for session file at '{0}'.", _persistenceDirectoryPath);
 
-            if (_options.FileSystem.CreateDirectory(_persistenceDirectoryPath) is not FileOperationResult.Success)
+            var result = _options.FileSystem.CreateDirectory(_persistenceDirectoryPath);
+            if (result is not FileOperationResult.Success)
             {
-                _options.LogError("Failed to create persistent directory for session file.");
+                if (result is FileOperationResult.Disabled)
+                {
+                    _options.LogInfo("Persistent directory for session file has not been created. File-write has been disabled via the options.");
+                }
+                else
+                {
+                    _options.LogError("Failed to create persistent directory for session file.");
+                }
+
                 return;
             }
 

diff --git a/src/Sentry/Http/HttpTransportBase.cs b/src/Sentry/Http/HttpTransportBase.cs
@@ -386,16 +386,17 @@ private void HandleFailure(HttpResponseMessage response, Envelope envelope)
                 var destination = Path.Combine(destinationDirectory, "envelope_too_large",
                     (eventId ?? SentryId.Create()).ToString());
 
-                if (_options.FileSystem.CreateDirectory(Path.GetDirectoryName(destination)!) is not FileOperationResult.Success)
+                var createDirectoryResult = _options.FileSystem.CreateDirectory(Path.GetDirectoryName(destination)!);
+                if (createDirectoryResult is not FileOperationResult.Success)
                 {
-                    _options.LogError("Failed to create directory to store the envelope.");
+                    _options.DiagnosticLogger.LogError("Failed to create directory to store the envelope: {0}", createDirectoryResult);
                     return;
                 }
 
                 var result = _options.FileSystem.CreateFileForWriting(destination, out var envelopeFile);
                 if (result is not FileOperationResult.Success)
                 {
-                    _options.LogError("Failed to create envelope file.");
+                    _options.DiagnosticLogger.LogError("Failed to create envelope file: {0}", result);
                     return;
                 }
 
@@ -451,16 +452,17 @@ private async Task HandleFailureAsync(HttpResponseMessage response, Envelope env
                 var destination = Path.Combine(destinationDirectory, "envelope_too_large",
                     (eventId ?? SentryId.Create()).ToString());
 
-                if (_options.FileSystem.CreateDirectory(Path.GetDirectoryName(destination)!) is not FileOperationResult.Success)
+                var createDirectoryResult = _options.FileSystem.CreateDirectory(Path.GetDirectoryName(destination)!);
+                if (createDirectoryResult is not FileOperationResult.Success)
                 {
-                    _options.LogError("Failed to create directory to store the envelope.");
+                    _options.DiagnosticLogger.LogError("Failed to create directory to store the envelope: {0}", createDirectoryResult);
                     return;
                 }
 
                 var result = _options.FileSystem.CreateFileForWriting(destination, out var envelopeFile);
                 if (result is not FileOperationResult.Success)
                 {
-                    _options.LogError("Failed to create envelope file.");
+                    _options.DiagnosticLogger.LogError("Failed to create envelope file: {0}", result);
                     return;
                 }