Unobsoleted SentryClient.Dispose (#2842)

Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
getsentry · Nov 17, 2023 · 34b8f9c · 34b8f9c
1 parent 2c0d18a
commit 34b8f9c
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@
 #### Changed APIs
 
 - `DebugImage` and `DebugMeta` moved to `Sentry.Protocol` namespace. ([#2815](https://github.com/getsentry/sentry-dotnet/pull/2815))
+- `SentryClient.Dispose` is no longer obsolete ([#2842](https://github.com/getsentry/sentry-dotnet/pull/2842))
 
 ## 4.0.0-alpha.0
 

diff --git a/src/Sentry/SentryClient.cs b/src/Sentry/SentryClient.cs
@@ -403,7 +403,6 @@ private bool CaptureEnvelope(Envelope envelope)
     /// Disposes this client
     /// </summary>
     /// <inheritdoc />
-    [Obsolete("Sentry client should not be explicitly disposed of. This method will be removed in version 4.")]
     public void Dispose()
     {
         _options.LogDebug("Flushing SentryClient.");

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt
@@ -482,8 +482,6 @@ namespace Sentry
         public void CaptureTransaction(Sentry.Transaction transaction) { }
         public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
         public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
-        [System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
-            "n version 4.")]
         public void Dispose() { }
         public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
     }

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt
@@ -482,8 +482,6 @@ namespace Sentry
         public void CaptureTransaction(Sentry.Transaction transaction) { }
         public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
         public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
-        [System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
-            "n version 4.")]
         public void Dispose() { }
         public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
     }

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
@@ -482,8 +482,6 @@ namespace Sentry
         public void CaptureTransaction(Sentry.Transaction transaction) { }
         public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
         public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
-        [System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
-            "n version 4.")]
         public void Dispose() { }
         public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
     }

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt
@@ -481,8 +481,6 @@ namespace Sentry
         public void CaptureTransaction(Sentry.Transaction transaction) { }
         public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
         public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
-        [System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
-            "n version 4.")]
         public void Dispose() { }
         public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
     }