move to ImplicitUsings (#1325)

Directory.Build.props

@@ -8,6 +8,7 @@
     <SignAssembly>true</SignAssembly>
     <Deterministic>true</Deterministic>
     <Features>strict</Features>
+    <ImplicitUsings>true</ImplicitUsings>
   </PropertyGroup>
 
   <!-- We're aware it's out of support but this is a library and it doesn't require nca3.1.  -->

Directory.Build.targets

@@ -0,0 +1,7 @@
+<Project>
+  <ItemGroup>
+    <!-- Workaround the fact that http doesnt exist in earlier frameworks -->
+    <Using Remove="System.Net.Http"/>
+    <Using Remove="System.Net.Http.Json"/>
+  </ItemGroup>
+</Project>

Sentry.sln

@@ -27,6 +27,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".root", ".root", "{9D7E2F87
 		CHANGELOG.md = CHANGELOG.md
 		CONTRIBUTING.md = CONTRIBUTING.md
 		Directory.Build.props = Directory.Build.props
+		Directory.Build.targets = Directory.Build.targets
 		README.md = README.md
 	EndProjectSection
 EndProject

benchmarks/Sentry.Benchmarks/BackgroundWorkerFlushBenchmarks.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;
 using Sentry.Extensibility;
 using Sentry.Internal;

benchmarks/Sentry.Benchmarks/BreadcrumbOverheadBenchmarks.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Collections.Generic;
 using BenchmarkDotNet.Attributes;
 
 namespace Sentry.Benchmarks;

benchmarks/Sentry.Benchmarks/CaptureExceptionDuplicateDetectionBenchmarks.cs

@@ -1,4 +1,3 @@
-using System;
 using BenchmarkDotNet.Attributes;
 
 namespace Sentry.Benchmarks;

benchmarks/Sentry.Benchmarks/FakeHttpClientFactory.cs

@@ -1,9 +1,6 @@
-using System;
 using System.Net;
 using System.Net.Http;
 using System.Net.Http.Headers;
-using System.Threading;
-using System.Threading.Tasks;
 using Sentry.Http;
 
 namespace Sentry.Benchmarks;

benchmarks/Sentry.Benchmarks/Program.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using BenchmarkDotNet.Configs;
 using BenchmarkDotNet.Diagnosers;
 using BenchmarkDotNet.Environments;

benchmarks/Sentry.Benchmarks/RetryAfterHandlerOverhead.cs

@@ -1,6 +1,5 @@
 using System.Net;
 using System.Net.Http;
-using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;
 using Sentry.Internal.Http;
 using static System.Threading.CancellationToken;

benchmarks/Sentry.Benchmarks/ScopeManagementBenchmarks.cs

@@ -1,4 +1,3 @@
-using System;
 using BenchmarkDotNet.Attributes;
 using Sentry.Extensibility;
 

benchmarks/Sentry.Benchmarks/SentryCoreInitAndDisposeBenchmarks.cs

@@ -1,4 +1,3 @@
-using System;
 using BenchmarkDotNet.Attributes;
 
 namespace Sentry.Benchmarks;

samples/Directory.Build.props

@@ -7,4 +7,9 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
+  <ItemGroup>
+    <Using Include="Sentry"/>
+    <Using Include="Sentry.Extensibility"/>
+    <Using Include="System.Diagnostics"/>
+  </ItemGroup>
 </Project>

samples/Sentry.Samples.AspNetCore.Basic/Program.cs

@@ -1,11 +1,4 @@
-using System;
 using Microsoft.AspNetCore;
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.AspNetCore.Routing;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
-using Sentry.AspNetCore;
 
 namespace Sentry.Samples.AspNetCore.Basic;
 

samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Program.cs

@@ -1,9 +1,5 @@
-using System;
 using System.Net.Http;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Components.WebAssembly.Hosting;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
 
 namespace Sentry.Samples.AspNetCore.Blazor.Wasm;
 

samples/Sentry.Samples.AspNetCore.Grpc/GameService.cs

@@ -1,10 +1,7 @@
-using System;
 using System.Data;
 using System.Net.Http;
-using System.Threading.Tasks;
 using Google.Protobuf.WellKnownTypes;
 using Grpc.Core;
-using Microsoft.Extensions.Logging;
 using Sentry.AspNetCore.Samples.Grpc;
 
 namespace Sentry.Samples.AspNetCore.Grpc;

samples/Sentry.Samples.AspNetCore.Grpc/Program.cs

@@ -1,7 +1,5 @@
-using System;
 using System.Net;
 using Microsoft.AspNetCore;
-using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Server.Kestrel.Core;
 using Sentry.AspNetCore;
 using Sentry.AspNetCore.Grpc;

samples/Sentry.Samples.AspNetCore.Grpc/Startup.cs

@@ -1,8 +1,3 @@
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Hosting;
-
 namespace Sentry.Samples.AspNetCore.Grpc;
 
 public class Startup

samples/Sentry.Samples.AspNetCore.Mvc/Controllers/HomeController.cs

@@ -1,10 +1,6 @@
-using System;
 using System.Diagnostics;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.Extensions.Logging;
 using Samples.AspNetCore.Mvc.Models;
-using Sentry;
 
 namespace Samples.AspNetCore.Mvc.Controllers;
 

samples/Sentry.Samples.AspNetCore.Mvc/ExampleEventProcessor.cs

@@ -1,7 +1,3 @@
-using Microsoft.AspNetCore.Http;
-using Sentry;
-using Sentry.Extensibility;
-
 namespace Samples.AspNetCore.Mvc;
 
 public class ExampleEventProcessor : ISentryEventProcessor

samples/Sentry.Samples.AspNetCore.Mvc/GameService.cs

@@ -1,8 +1,5 @@
-using System;
 using System.Data;
 using System.Net.Http;
-using System.Threading.Tasks;
-using Microsoft.Extensions.Logging;
 
 namespace Samples.AspNetCore.Mvc;
 

samples/Sentry.Samples.AspNetCore.Mvc/Program.cs

@@ -1,7 +1,5 @@
-using System;
 using System.Net;
 using Microsoft.AspNetCore;
-using Microsoft.AspNetCore.Hosting;
 
 namespace Samples.AspNetCore.Mvc;
 

samples/Sentry.Samples.AspNetCore.Mvc/SpecialException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace Samples.AspNetCore.Mvc;
 
 public class SpecialException : Exception

samples/Sentry.Samples.AspNetCore.Mvc/SpecialExceptionProcessor.cs

@@ -1,6 +1,3 @@
-using Sentry;
-using Sentry.Extensibility;
-
 namespace Samples.AspNetCore.Mvc;
 
 public class SpecialExceptionProcessor : SentryEventExceptionProcessor<SpecialException>

samples/Sentry.Samples.AspNetCore.Mvc/Startup.cs

@@ -1,11 +1,3 @@
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.Configuration;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Hosting;
-using Sentry.AspNetCore;
-using Sentry.Extensibility;
-
 namespace Samples.AspNetCore.Mvc;
 
 public class Startup

samples/Sentry.Samples.AspNetCore.Serilog/Program.cs

@@ -1,9 +1,4 @@
-using System;
 using Microsoft.AspNetCore;
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
 using Serilog;
 using Serilog.Events;
 

samples/Sentry.Samples.AspNetCore5.Mvc/Controllers/HomeController.cs

@@ -1,6 +1,4 @@
-using System.Diagnostics;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.Extensions.Logging;
 using Sentry.Samples.AspNetCore3.Mvc.Models;
 
 namespace Samples.AspNetCore5.Mvc.Controllers;

samples/Sentry.Samples.AspNetCore5.Mvc/Program.cs

@@ -1,8 +1,4 @@
-using System;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.Hosting;
 using Sentry.AspNetCore;
-using Sentry.Extensibility;
 
 namespace Sentry.Samples.AspNetCore5.Mvc;
 

samples/Sentry.Samples.AspNetCore5.Mvc/Startup.cs

@@ -1,10 +1,3 @@
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.Configuration;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Hosting;
-using Sentry.AspNetCore;
-
 namespace Sentry.Samples.AspNetCore5.Mvc;
 
 public class Startup

samples/Sentry.Samples.Aws.Lambda.AspNetCoreServer/LambdaEntryPoint.cs

@@ -1,5 +1,3 @@
-using Microsoft.AspNetCore.Hosting;
-
 // The entrypoint used when the function is deployed to AWS.
 public class LambdaEntryPoint : Amazon.Lambda.AspNetCoreServer.APIGatewayProxyFunction
 {

samples/Sentry.Samples.Aws.Lambda.AspNetCoreServer/LocalEntryPoint.cs

@@ -1,5 +1,4 @@
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.Hosting;
+
 
 // Only used for testing locally: dotnet run
 public static class LocalEntryPoint

samples/Sentry.Samples.Aws.Lambda.AspNetCoreServer/Startup.cs

@@ -1,8 +1,3 @@
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.Configuration;
-using Microsoft.Extensions.DependencyInjection;
-
 public class Startup
 {
     public Startup(IConfiguration configuration) => Configuration = configuration;

samples/Sentry.Samples.Console.Basic/Program.cs

@@ -1,5 +1,3 @@
-using Sentry;
-
 using (SentrySdk.Init("https://eb18e953812b41c3aeb042e666fd3b5c@o447951.ingest.sentry.io/5428537"))
 {
     // The following exception is captured and sent to Sentry

samples/Sentry.Samples.Console.Customized/Program.cs

@@ -1,10 +1,6 @@
-using System;
 using System.Net.Http;
 using System.Reflection;
-using System.Threading.Tasks;
 using System.Xml.Xsl;
-using Sentry;
-using Sentry.Extensibility;
 
 // One of the ways to set your DSN is via an attribute:
 // It could be set via AssemblyInfo.cs and patched via CI.

samples/Sentry.Samples.EntityFramework/Program.cs

@@ -1,9 +1,6 @@
-using System;
 using System.ComponentModel.DataAnnotations;
 using System.Data.Common;
 using System.Data.Entity;
-using System.Linq;
-using Sentry;
 
 using var _ = SentrySdk.Init(o =>
 {

samples/Sentry.Samples.GenericHost/Program.cs

@@ -1,4 +1,3 @@
-using System.IO;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;

samples/Sentry.Samples.GenericHost/SampleHostedService.cs

@@ -1,9 +1,5 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
-using Sentry;
 
 internal class SampleHostedService : IHostedService
 {

samples/Sentry.Samples.Google.Cloud.Functions/Function.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Threading.Tasks;
 using Google.Cloud.Functions.Framework;
 using Google.Cloud.Functions.Hosting;
 using Microsoft.AspNetCore.Http;

samples/Sentry.Samples.Log4Net/Program.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Security.Principal;
 using log4net;
 using log4net.Config;

samples/Sentry.Samples.ME.Logging/Program.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
 using Microsoft.Extensions.Logging;
-using Sentry;
 using Sentry.Extensions.Logging;
 
 internal class Program

samples/Sentry.Samples.NLog/Program.cs

@@ -1,4 +1,3 @@
-using System;
 using NLog;
 using NLog.Config;
 using NLog.Targets;

samples/Sentry.Samples.Serilog/Program.cs

@@ -1,4 +1,3 @@
-using System;
 using Serilog;
 using Serilog.Context;
 using Serilog.Events;

src/Sentry.AspNet/Internal/HttpContextScopeStackContainer.cs

@@ -1,4 +1,3 @@
-using System.Collections.Generic;
 using System.Web;
 using Sentry.Internal.ScopeStack;
 

src/Sentry.AspNet/Internal/SystemWebHttpRequest.cs

@@ -1,6 +1,3 @@
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
 using System.Web;
 using Sentry.Extensibility;
 

src/Sentry.AspNet/Internal/SystemWebRequestEventProcessor.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Security.Claims;
 using System.Web;
 using Sentry.Extensibility;

src/Sentry.AspNetCore.Grpc/ProtobufRequestExtractionDispatcher.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Collections.Generic;
 using Google.Protobuf;
 using Sentry.Extensibility;
 

src/Sentry.AspNetCore.Grpc/ScopeExtensions.cs

@@ -1,4 +1,3 @@
-using System.Collections.Generic;
 using System.ComponentModel;
 using Google.Protobuf;
 using Grpc.Core;

src/Sentry.AspNetCore.Grpc/SentryGrpcInterceptor.cs

@@ -1,6 +1,4 @@
-using System;
 using System.Runtime.ExceptionServices;
-using System.Threading.Tasks;
 using Grpc.Core;
 using Grpc.Core.Interceptors;
 using Microsoft.Extensions.Options;

src/Sentry.AspNetCore/ApplicationBuilderExtensions.cs

@@ -1,6 +1,4 @@
-using System.Collections.Generic;
 using System.ComponentModel;
-using System.Linq;
 #if NETSTANDARD2_0
 using IHostApplicationLifetime = Microsoft.AspNetCore.Hosting.IApplicationLifetime;
 #else

src/Sentry.AspNetCore/AspNetCoreEventProcessor.cs

@@ -1,4 +1,3 @@
-using System;
 using Sentry.Extensibility;
 using Sentry.Protocol;
 using OperatingSystem = Sentry.Protocol.OperatingSystem;

src/Sentry.AspNetCore/AspNetCoreExceptionProcessor.cs

@@ -1,4 +1,3 @@
-using System;
 using Sentry.Extensibility;
 using Sentry.Protocol;
 

src/Sentry.AspNetCore/HttpRequestAdapter.cs

@@ -1,6 +1,3 @@
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
 using Microsoft.AspNetCore.Http;
 using Sentry.Extensibility;
 

src/Sentry.AspNetCore/SamplingExtensions.cs

@@ -1,5 +1,3 @@
-using System.Collections.Generic;
-
 namespace Sentry.AspNetCore;
 
 /// <summary>

src/Sentry.AspNetCore/ScopeExtensions.cs

@@ -1,8 +1,5 @@
-using System;
-using System.Collections.Generic;
 using System.ComponentModel;
 using System.Diagnostics;
-using System.Linq;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.Extensions.DependencyInjection;