Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nuxt): Describe run script more precisely #11064

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 13, 2024

DESCRIBE YOUR PR

Better explanation for script setup and import variable.
ref: getsentry/sentry-javascript#13304

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 11:37am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 11:37am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 11:37am

Copy link

codecov bot commented Aug 13, 2024

Bundle Report

Changes will decrease total bundle size by 19 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.24MB 10 bytes ⬇️
sentry-docs-edge-server 254.16kB 3 bytes ⬇️
sentry-docs-client 6.25MB 6 bytes ⬇️

Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@s1gr1d s1gr1d merged commit 1b8a47d into master Aug 13, 2024
9 checks passed
@s1gr1d s1gr1d deleted the sig/nuxt-scripts branch August 13, 2024 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants