Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replay quality setting #2582

Merged
merged 8 commits into from
Jan 20, 2025
Merged

feat: replay quality setting #2582

merged 8 commits into from
Jan 20, 2025

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jan 17, 2025

📜 Description

💡 Motivation and Context

Closes #2557

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- replay quality setting ([#2582](https://github.com/getsentry/sentry-dart/pull/2582))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 10e307c

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (1eca72b) to head (10e307c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2582      +/-   ##
==========================================
+ Coverage   88.85%   92.63%   +3.77%     
==========================================
  Files         122       91      -31     
  Lines        4324     3013    -1311     
==========================================
- Hits         3842     2791    -1051     
+ Misses        482      222     -260     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 460.64 ms 533.12 ms 72.48 ms
Size 6.46 MiB 7.48 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8ced2dc 295.58 ms 336.49 ms 40.91 ms
9f05645 349.43 ms 437.24 ms 87.81 ms
3adbea9 395.16 ms 447.88 ms 52.71 ms
f735167 404.38 ms 412.57 ms 8.19 ms
6a5a65d 410.26 ms 503.91 ms 93.65 ms
33d0587 308.79 ms 370.86 ms 62.07 ms
6d317ea 303.46 ms 356.06 ms 52.60 ms
256df44 447.58 ms 485.84 ms 38.25 ms
ed605cc 317.48 ms 374.24 ms 56.76 ms
3d305b9 403.55 ms 469.76 ms 66.20 ms

App size

Revision Plain With Sentry Diff
8ced2dc 6.06 MiB 7.03 MiB 990.29 KiB
9f05645 6.27 MiB 7.20 MiB 958.60 KiB
3adbea9 6.52 MiB 7.61 MiB 1.09 MiB
f735167 6.46 MiB 7.48 MiB 1.01 MiB
6a5a65d 6.35 MiB 7.41 MiB 1.05 MiB
33d0587 6.16 MiB 7.14 MiB 1007.47 KiB
6d317ea 5.94 MiB 6.92 MiB 1001.74 KiB
256df44 6.52 MiB 7.59 MiB 1.06 MiB
ed605cc 6.06 MiB 7.03 MiB 993.53 KiB
3d305b9 6.35 MiB 7.35 MiB 1021.16 KiB

Previous results on branch: feat/replay-quality-setting

Startup times

Revision Plain With Sentry Diff
4ea7a4a 433.07 ms 503.74 ms 70.67 ms
8165dcf 469.13 ms 580.57 ms 111.44 ms

App size

Revision Plain With Sentry Diff
4ea7a4a 6.46 MiB 7.48 MiB 1.03 MiB
8165dcf 6.46 MiB 7.48 MiB 1.03 MiB

Copy link
Contributor

github-actions bot commented Jan 17, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1255.08 ms 1283.61 ms 28.53 ms
Size 8.42 MiB 9.89 MiB 1.47 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7954fb3 1247.20 ms 1272.15 ms 24.94 ms
8ced2dc 1258.35 ms 1272.98 ms 14.62 ms
d0312c9 1205.55 ms 1224.45 ms 18.90 ms
25e9b59 1289.76 ms 1295.27 ms 5.51 ms
754cdbe 1261.67 ms 1280.88 ms 19.20 ms
e3ef570 1220.08 ms 1239.66 ms 19.58 ms
f275487 1291.65 ms 1339.92 ms 48.26 ms
cecd4ed 1232.88 ms 1250.65 ms 17.78 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms
c1bb00f 1265.14 ms 1290.85 ms 25.71 ms

App size

Revision Plain With Sentry Diff
7954fb3 8.38 MiB 9.75 MiB 1.37 MiB
8ced2dc 8.10 MiB 9.16 MiB 1.07 MiB
d0312c9 8.32 MiB 9.39 MiB 1.06 MiB
25e9b59 8.16 MiB 9.15 MiB 1021.15 KiB
754cdbe 8.29 MiB 9.37 MiB 1.08 MiB
e3ef570 8.32 MiB 9.38 MiB 1.06 MiB
f275487 8.32 MiB 9.38 MiB 1.05 MiB
cecd4ed 8.38 MiB 9.75 MiB 1.37 MiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB
c1bb00f 8.09 MiB 9.07 MiB 1001.06 KiB

Previous results on branch: feat/replay-quality-setting

Startup times

Revision Plain With Sentry Diff
8165dcf 1251.78 ms 1264.47 ms 12.69 ms
4ea7a4a 1244.35 ms 1264.53 ms 20.18 ms

App size

Revision Plain With Sentry Diff
8165dcf 8.42 MiB 9.89 MiB 1.47 MiB
4ea7a4a 8.42 MiB 9.89 MiB 1.47 MiB

@vaind vaind marked this pull request as ready for review January 17, 2025 13:43
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vaind vaind merged commit ea6d86d into main Jan 20, 2025
53 of 54 checks passed
@vaind vaind deleted the feat/replay-quality-setting branch January 20, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replay: add quality configuration
2 participants