Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0 js sdk integration #2572

Merged
merged 12 commits into from
Jan 14, 2025
Merged

v0 js sdk integration #2572

merged 12 commits into from
Jan 14, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 13, 2025 •
edited
Loading

📜 Description

This branch contains multiple merged and reviewed PRs

Adding release health support is currently blocked by JS v9

💡 Motivation and Context

JS SDK integration

This PR only adds changelog

@buenaflor
feat(js-sdk): add script loader to set up Sentry Javascript SDK (#2406)
2e89903 
* update

* update

* updaet

* Update sentry_js_sdk_version.dart

* temporary ci change

* fix test

* fix compilation

* fix compilation

* fix

* fix test

* update

* fix test

* fix test

* update

* update

* update

* fix analyze

* update

* update

* update validation

* update

* update

* update

* rethrow on automated test mode

* update rethrow

* update

* update tests

* update appending

* update web

* add trusted types and add tests

* formatting

* update comment

* add as browser test

* fix min_version

* fix warnings

* add another test file

* update

* update comment

* try out web integration test

* update

* use ubuntu latest for web

* see if it runs

* update

* fix job

* fix job

* run chromedriver in background

* run correct port

* update

* update

* setup chrome action

* update

* run chrome first

* try

* update

* update

* remove file

* update

* update

* fix tests

* update

* update docs and test cases

* add todo

* update

* update

* add doc and fix tests

* update tests

* update

* update

* Update web_sdk_test.dart

* add test with automatedTestMode false

* update

* remove debug

* remove fn

* update restore flutter onError

* fix analyze

* Update flutter.yml
@buenaflor
Merge branch 'main' into feat/js-sdk-integration
ce857e4
@buenaflor
Merge branch 'main' into feat/js-sdk-integration
6f566c4
@buenaflor
Merge branch 'main' into feat/js-sdk-integration
131d644
@buenaflor
Merge branch 'main' into feat/js-sdk-integration
d2a808c
@buenaflor
Merge branch 'main' into feat/js-sdk-integration
7017668
@buenaflor
feat: sentry web api (#2489)
00bb02a 
* update

* update

* update test

* update

* update

* update

* update

* update doc

* update

* update

* update

* update test

* update

* update tests

* use tryCatchSync

* formatting

* fix sentry_flutter_test

* fix analyze

* update test

* fix tests

* update test

* update test

* update scripts

* ignore sentry_web in coverage

* update test

* temporary

* update

* test

* update tests

* update test with mocks

* fix analyze

* update

* update names

* fix test

* update

* update integration

* update comment

* update flutter enricher

* update test

* update

* update flag name

* update

* update binding creation condition

* update

* update integration test

* fix tests
@buenaflor
Merge branch 'main' into feat/js-sdk-integration
b5efca7
@buenaflor
feat(js-sdk): enable global error handler and dedupe integration (#2566)
9484a42 
* add default integrations

* fix integration test
@buenaflor
feat(js-sdk): use js transport (#2563)
9c5e6aa 
* add envelope sending

* add test

* add test

* update message

* update payload api

* update

* update payload api

* revert hasNativeIntegration

* update

* dont remove scope observer

* fix integration test

* cleanup

* update test

* update test

* cleanup integration test

* improve envelope capturing

* clean up

* fix analyze

* fix tests

* update

* formatting

* fix integration test

* use buckets

* fix log string

* update mocks

* update mocks

* process succeessful envelope items
@buenaflor
Merge branch 'main' into feat/js-sdk-integration
f5882ad
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f765755

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (ec50b21) to head (f765755).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dart/lib/src/platform_checker.dart 0.00% 7 Missing ⚠️
flutter/lib/src/native/sentry_native_channel.dart 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2572      +/-   ##
==========================================
- Coverage   87.35%   87.29%   -0.07%     
==========================================
  Files         269      268       -1     
  Lines        9531     9342     -189     
==========================================
- Hits         8326     8155     -171     
+ Misses       1205     1187      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 470.66 ms 536.40 ms 65.74 ms
Size 6.46 MiB 7.48 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3de8b9b 348.55 ms 445.84 ms 97.29 ms
6d50a9b 467.98 ms 526.48 ms 58.50 ms
3a16179 471.61 ms 513.45 ms 41.83 ms
ebfead1 298.44 ms 374.28 ms 75.84 ms
f056db1 426.04 ms 475.76 ms 49.72 ms
2a0edba 376.12 ms 454.00 ms 77.88 ms
256df44 447.58 ms 485.84 ms 38.25 ms
ef31c7f 311.39 ms 359.33 ms 47.94 ms
c978477 347.00 ms 409.94 ms 62.94 ms
3500574 288.69 ms 358.34 ms 69.65 ms

App size

Revision Plain With Sentry Diff
3de8b9b 6.27 MiB 7.20 MiB 957.75 KiB
6d50a9b 6.49 MiB 7.55 MiB 1.06 MiB
3a16179 6.52 MiB 7.61 MiB 1.08 MiB
ebfead1 6.06 MiB 7.03 MiB 989.24 KiB
f056db1 6.52 MiB 7.61 MiB 1.09 MiB
2a0edba 6.33 MiB 7.30 MiB 992.46 KiB
256df44 6.52 MiB 7.59 MiB 1.06 MiB
ef31c7f 6.06 MiB 7.09 MiB 1.03 MiB
c978477 6.33 MiB 7.29 MiB 987.32 KiB
3500574 6.16 MiB 7.14 MiB 1009.90 KiB

Previous results on branch: feat/js-sdk-integration

Startup times

Revision Plain With Sentry Diff
7017668 435.40 ms 491.43 ms 56.03 ms
ce857e4 436.45 ms 482.72 ms 46.27 ms
00bb02a 453.42 ms 557.82 ms 104.40 ms
13c8257 466.00 ms 520.80 ms 54.80 ms
9484a42 447.21 ms 495.64 ms 48.43 ms
b5efca7 452.79 ms 500.04 ms 47.25 ms
131d644 484.74 ms 552.91 ms 68.17 ms

App size

Revision Plain With Sentry Diff
7017668 6.46 MiB 7.48 MiB 1.02 MiB
ce857e4 6.49 MiB 7.57 MiB 1.08 MiB
00bb02a 6.46 MiB 7.48 MiB 1.01 MiB
13c8257 6.49 MiB 7.56 MiB 1.07 MiB
9484a42 6.46 MiB 7.48 MiB 1.01 MiB
b5efca7 6.46 MiB 7.48 MiB 1.01 MiB
131d644 6.46 MiB 7.49 MiB 1.02 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1251.92 ms 1266.70 ms 14.79 ms
Size 8.42 MiB 9.89 MiB 1.46 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a40bb7c 1222.75 ms 1240.88 ms 18.13 ms
6689749 1243.66 ms 1251.94 ms 8.28 ms
29297d4 1245.82 ms 1276.57 ms 30.76 ms
72dfc83 1262.50 ms 1289.75 ms 27.25 ms
89ea268 1252.33 ms 1253.58 ms 1.26 ms
9d43f71 1225.06 ms 1227.06 ms 2.00 ms
aed5947 1268.67 ms 1281.10 ms 12.43 ms
8e133ad 1268.19 ms 1277.37 ms 9.18 ms
2261c15 1249.49 ms 1259.69 ms 10.20 ms
dd76eef 1222.51 ms 1258.38 ms 35.87 ms

App size

Revision Plain With Sentry Diff
a40bb7c 8.38 MiB 9.73 MiB 1.35 MiB
6689749 8.38 MiB 9.78 MiB 1.40 MiB
29297d4 8.33 MiB 9.40 MiB 1.07 MiB
72dfc83 8.15 MiB 9.12 MiB 987.30 KiB
89ea268 8.09 MiB 9.16 MiB 1.06 MiB
9d43f71 8.29 MiB 9.39 MiB 1.10 MiB
aed5947 8.16 MiB 9.17 MiB 1.01 MiB
8e133ad 8.10 MiB 9.16 MiB 1.07 MiB
2261c15 8.28 MiB 9.34 MiB 1.06 MiB
dd76eef 8.33 MiB 9.64 MiB 1.31 MiB

Previous results on branch: feat/js-sdk-integration

Startup times

Revision Plain With Sentry Diff
131d644 1240.96 ms 1266.36 ms 25.40 ms
b5efca7 1252.22 ms 1271.82 ms 19.60 ms
ce857e4 1253.85 ms 1281.67 ms 27.82 ms
9484a42 1245.45 ms 1275.81 ms 30.36 ms
13c8257 1236.43 ms 1256.17 ms 19.74 ms
00bb02a 1245.67 ms 1270.55 ms 24.88 ms
7017668 1249.16 ms 1264.24 ms 15.08 ms

App size

Revision Plain With Sentry Diff
131d644 8.42 MiB 9.83 MiB 1.41 MiB
b5efca7 8.42 MiB 9.88 MiB 1.46 MiB
ce857e4 8.38 MiB 9.78 MiB 1.41 MiB
9484a42 8.42 MiB 9.88 MiB 1.46 MiB
13c8257 8.38 MiB 9.77 MiB 1.39 MiB
00bb02a 8.42 MiB 9.86 MiB 1.44 MiB
7017668 8.42 MiB 9.86 MiB 1.44 MiB

JoshuaMoelans
JoshuaMoelans approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@buenaflor buenaflor merged commit f27eaee into main Jan 14, 2025
144 checks passed
@buenaflor buenaflor deleted the feat/js-sdk-integration branch January 14, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaMoelans JoshuaMoelans JoshuaMoelans approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buenaflor @JoshuaMoelans