feat: replay orientation change

flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

@@ -2,6 +2,7 @@ package io.sentry.flutter
 
 import android.app.Activity
 import android.content.Context
+import android.content.res.Configuration;
 import android.os.Build
 import android.os.Looper
 import android.util.Log
@@ -27,13 +28,15 @@ import io.sentry.android.core.SentryAndroidOptions
 import io.sentry.android.core.performance.AppStartMetrics
 import io.sentry.android.core.performance.TimeSpan
 import io.sentry.android.replay.ReplayIntegration
+import io.sentry.android.replay.ScreenshotRecorderConfig
 import io.sentry.protocol.DebugImage
 import io.sentry.protocol.SdkVersion
 import io.sentry.protocol.SentryId
 import io.sentry.protocol.User
 import io.sentry.transport.CurrentDateProvider
 import java.io.File
 import java.lang.ref.WeakReference
+import kotlin.math.roundToInt
 
 private const val APP_START_MAX_DURATION_MS = 60000
 
@@ -42,6 +45,14 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
   private lateinit var context: Context
   private lateinit var sentryFlutter: SentryFlutter
   private lateinit var replay: ReplayIntegration
+  private var replayConfig = ScreenshotRecorderConfig(
+    recordingWidth = 0,
+    recordingHeight = 0,
+    scaleFactorX = 1.0f,
+    scaleFactorY = 1.0f,
+    frameRate = 0,
+    bitRate = 0
+  )
 
   private var activity: WeakReference<Activity>? = null
   private var framesTracker: ActivityFramesTracker? = null
@@ -86,6 +97,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
       "loadContexts" -> loadContexts(result)
       "displayRefreshRate" -> displayRefreshRate(result)
       "nativeCrash" -> crash()
+      "setReplayConfig" -> setReplayConfig(call, result)
       "addReplayScreenshot" -> addReplayScreenshot(call.argument("path"), call.argument("timestamp"), result)
       "captureReplay" -> captureReplay(call.argument("isCrash"), result)
       else -> result.notImplemented()
@@ -152,7 +164,13 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
             context,
             dateProvider = CurrentDateProvider.getInstance(),
             recorderProvider = { SentryFlutterReplayRecorder(channel, replay) },
-            recorderConfigProvider = null,
+            recorderConfigProvider = {
+              Log.i(
+                "Sentry",
+                "Replay configuration requested. Returning: %dx%d at %d FPS, %d BPS".format(replayConfig.recordingWidth, replayConfig.recordingHeight, replayConfig.frameRate, replayConfig.bitRate)
+              )
+              replayConfig
+            },
             replayCacheProvider = null,
           )
         replay.breadcrumbConverter = SentryFlutterReplayBreadcrumbConverter()
@@ -181,6 +199,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
         "Invalid app start data: app not launched in foreground or app start took too long (>60s)",
       )
       result.success(null)
+      return
     }
 
     val appStartTimeSpan = appStartMetrics.appStartTimeSpan
@@ -546,6 +565,20 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
       mainThread.uncaughtExceptionHandler.uncaughtException(mainThread, exception)
       mainThread.join(NATIVE_CRASH_WAIT_TIME)
     }
+
+    /**
+     * Since codec block size is 16, so we have to adjust the width and height to it, otherwise
+     * the codec might fail to configure on some devices, see
+     * https://cs.android.com/android/platform/superproject/+/master:frameworks/base/media/java/android/media/MediaCodecInfo.java;l=1999-2001
+     */
+    private fun Int.adjustReplaySizeToBlockSize(): Int {
+        val remainder = this % 16
+        return if (remainder <= 8) {
+            this - remainder
+        } else {
+            this + (16 - remainder)
+        }
+    }
   }
 
   private fun loadContexts(result: Result) {
@@ -577,6 +610,23 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
     result.success("")
   }
 
+  private fun setReplayConfig(call: MethodCall, result: Result) {
+    replayConfig = ScreenshotRecorderConfig(
+      recordingWidth = (call.argument("width") as? Int)?.adjustReplaySizeToBlockSize() ?: 0,
+      recordingHeight = (call.argument("height") as? Int)?.adjustReplaySizeToBlockSize() ?: 0,
+      scaleFactorX = 1.0f,
+      scaleFactorY = 1.0f,
+      frameRate = call.argument("frameRate") as? Int ?: 0,
+      bitRate = call.argument("bitRate") as? Int ?: 0
+    )
+    Log.i(
+      "Sentry",
+      "Configuring replay: %dx%d at %d FPS, %d BPS".format(replayConfig.recordingWidth, replayConfig.recordingHeight, replayConfig.frameRate, replayConfig.bitRate)
+    )
+    replay.onConfigurationChanged(Configuration())
+    result.success("")
+  }
+
   private fun captureReplay(
     isCrash: Boolean?,
     result: Result,

flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplayRecorder.kt

@@ -13,6 +13,12 @@ internal class SentryFlutterReplayRecorder(
   private val integration: ReplayIntegration,
 ) : Recorder {
   override fun start(recorderConfig: ScreenshotRecorderConfig) {
+    // Ignore if this is the initial call before we actually got the configuration from Flutter.
+    // We'll get another call here when the configuration is set.
+    if (recorderConfig.recordingHeight == 0 && recorderConfig.recordingWidth == 0) {
+      return;
+    }
+
     val cacheDirPath = integration.replayCacheDir?.absolutePath
     if (cacheDirPath == null) {
       Log.w("Sentry", "Replay cache directory is null, can't start replay recorder.")

flutter/lib/src/native/c/sentry_native.dart

@@ -8,6 +8,7 @@
 import 'package:meta/meta.dart';
 
 import '../../../sentry_flutter.dart';
+import '../../replay/replay_config.dart';
 import '../native_app_start.dart';
 import '../native_frames.dart';
 import '../sentry_native_binding.dart';
@@ -268,6 +269,14 @@
     Pointer.fromAddress(1).cast<Utf8>().toDartString();
   }
 
+  @override
+  bool get supportsReplay => false;
+
+  @override
+  FutureOr<void> setReplayConfig(ReplayConfig config) {
+    _logNotSupported('replay config');
+  }
+
   @override
   FutureOr<SentryId> captureReplay(bool isCrash) {
     _logNotSupported('capturing replay');

flutter/lib/src/native/cocoa/sentry_native_cocoa.dart

@@ -5,10 +5,8 @@ import 'dart:ui';
 import 'package:meta/meta.dart';
 
 import '../../../sentry_flutter.dart';
-import '../../event_processor/replay_event_processor.dart';
 import '../../screenshot/recorder.dart';
 import '../../screenshot/recorder_config.dart';
-import '../../replay/integration.dart';
 import '../sentry_native_channel.dart';
 import 'binding.dart' as cocoa;
 
@@ -20,19 +18,14 @@ class SentryNativeCocoa extends SentryNativeChannel {
 
   SentryNativeCocoa(super.options);
 
+  @override
+  bool get supportsReplay => options.platformChecker.platform.isIOS;
+
   @override
   Future<void> init(Hub hub) async {
     // We only need these when replay is enabled (session or error capture)
     // so let's set it up conditionally. This allows Dart to trim the code.
-    if (options.experimental.replay.isEnabled &&
-        options.platformChecker.platform.isIOS) {
-      options.sdk.addIntegration(replayIntegrationName);
-
-      // We only need the integration when error-replay capture is enabled.
-      if ((options.experimental.replay.onErrorSampleRate ?? 0) > 0) {
-        options.addEventProcessor(ReplayEventProcessor(hub, this));
-      }
-
+    if (options.experimental.replay.isEnabled) {
       channel.setMethodCallHandler((call) async {
         switch (call.method) {
           case 'captureReplayScreenshot':

flutter/lib/src/native/java/sentry_native_java.dart

@@ -4,8 +4,6 @@ import 'package:flutter/services.dart';
 import 'package:meta/meta.dart';
 
 import '../../../sentry_flutter.dart';
-import '../../event_processor/replay_event_processor.dart';
-import '../../replay/integration.dart';
 import '../../replay/scheduled_recorder.dart';
 import '../../replay/scheduled_recorder_config.dart';
 import '../sentry_native_channel.dart';
@@ -19,18 +17,14 @@ class SentryNativeJava extends SentryNativeChannel {
   _IdleFrameFiller? _idleFrameFiller;
   SentryNativeJava(super.options);
 
+  @override
+  bool get supportsReplay => true;
+
   @override
   Future<void> init(Hub hub) async {
     // We only need these when replay is enabled (session or error capture)
     // so let's set it up conditionally. This allows Dart to trim the code.
     if (options.experimental.replay.isEnabled) {
-      options.sdk.addIntegration(replayIntegrationName);
-
-      // We only need the integration when error-replay capture is enabled.
-      if ((options.experimental.replay.onErrorSampleRate ?? 0) > 0) {
-        options.addEventProcessor(ReplayEventProcessor(hub, this));
-      }
-
       channel.setMethodCallHandler((call) async {
         switch (call.method) {
           case 'ReplayRecorder.start':

flutter/lib/src/native/sentry_native_binding.dart

@@ -4,6 +4,7 @@ import 'dart:typed_data';
 import 'package:meta/meta.dart';
 
 import '../../sentry_flutter.dart';
+import '../replay/replay_config.dart';
 import 'native_app_start.dart';
 import 'native_frames.dart';
 
@@ -64,5 +65,9 @@ abstract class SentryNativeBinding {
 
   FutureOr<void> nativeCrash();
 
+  bool get supportsReplay;
+
+  FutureOr<void> setReplayConfig(ReplayConfig config);
+
   FutureOr<SentryId> captureReplay(bool isCrash);
 }

flutter/lib/src/native/sentry_native_channel.dart

@@ -7,6 +7,7 @@
 import 'package:meta/meta.dart';
 
 import '../../sentry_flutter.dart';
+import '../replay/replay_config.dart';
 import 'native_app_start.dart';
 import 'native_frames.dart';
 import 'method_channel_helper.dart';
@@ -216,6 +217,18 @@
   @override
   Future<void> nativeCrash() => channel.invokeMethod('nativeCrash');
 
+  @override
+  bool get supportsReplay => false;
+
+  @override
+  Future<void> setReplayConfig(ReplayConfig config) =>
+      channel.invokeMethod('setReplayConfig', {
+        'width': config.width,
+        'height': config.height,
+        'frameRate': config.frameRate,
+        'bitRate': config.bitRate,
+      });
+
   @override
   Future<SentryId> captureReplay(bool isCrash) =>
       channel.invokeMethod('captureReplay', {

flutter/lib/src/replay/integration.dart

@@ -1,6 +1,42 @@
+import 'dart:async';
+
 import 'package:meta/meta.dart';
 
-/// We don't actually have an integration, just want to have a name reported
-/// on events so we can filter them out.
+import '../../sentry_flutter.dart';
+import '../event_processor/replay_event_processor.dart';
+import '../native/sentry_native_binding.dart';
+import 'replay_config.dart';
+
 @internal
 const replayIntegrationName = 'ReplayIntegration';
+
+@internal
+class ReplayIntegration extends Integration<SentryFlutterOptions> {
+  final SentryNativeBinding _native;
+
+  ReplayIntegration(this._native);
+
+  @override
+  FutureOr<void> call(Hub hub, SentryFlutterOptions options) {
+    if (_native.supportsReplay && options.experimental.replay.isEnabled) {
+      options.sdk.addIntegration(replayIntegrationName);
+
+      // We only need the integration when error-replay capture is enabled.
+      if ((options.experimental.replay.onErrorSampleRate ?? 0) > 0) {
+        options.addEventProcessor(ReplayEventProcessor(hub, _native));
+      }
+
+      SentryScreenshotWidget.onBuild((status, prevStatus) {
+        if (status != prevStatus) {
+          _native.setReplayConfig(ReplayConfig(
+            width: status.size?.width.round() ?? 0,
+            height: status.size?.height.round() ?? 0,
+            frameRate: 1,
+            bitRate: 75000, // TODO replay quality config
+          ));
+        }
+        return true;
+      });
+    }
+  }
+}

flutter/lib/src/replay/replay_config.dart

@@ -0,0 +1,22 @@
+import 'package:meta/meta.dart';
+
+import 'scheduled_recorder_config.dart';
+
+@immutable
+@internal
+class ReplayConfig extends ScheduledScreenshotRecorderConfig {
+  @override
+  int get width => super.width!;
+
+  @override
+  int get height => super.height!;
+
+  final int bitRate;
+
+  const ReplayConfig({
+    required int super.width,
+    required int super.height,
+    required super.frameRate,
+    required this.bitRate,
+  });
+}

flutter/lib/src/replay/scheduled_recorder_config.dart

@@ -3,7 +3,7 @@ import '../screenshot/recorder_config.dart';
 class ScheduledScreenshotRecorderConfig extends ScreenshotRecorderConfig {
   final int frameRate;
 
-  ScheduledScreenshotRecorderConfig({
+  const ScheduledScreenshotRecorderConfig({
     super.width,
     super.height,
     required this.frameRate,

flutter/lib/src/screenshot/recorder_config.dart

@@ -7,7 +7,7 @@ class ScreenshotRecorderConfig {
   final int? width;
   final int? height;
 
-  ScreenshotRecorderConfig({
+  const ScreenshotRecorderConfig({
     this.width,
     this.height,
   });