Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: cache parsed dsn #2365

Merged
merged 9 commits into from
Oct 22, 2024
Merged

enh: cache parsed dsn #2365

merged 9 commits into from
Oct 22, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 17, 2024

📜 Description

Parses and caches the dsn when accessing it.

💡 Motivation and Context

Previously we parse it every time when we access it instead of caching it

Closes #2364

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (136c365) to head (7b4d8c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   84.76%   84.78%   +0.01%     
==========================================
  Files         253      253              
  Lines        9059     9070      +11     
==========================================
+ Hits         7679     7690      +11     
  Misses       1380     1380              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 468.73 ms 518.88 ms 50.15 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fe4aa56 356.06 ms 428.67 ms 72.61 ms
d53c6fa 282.83 ms 344.00 ms 61.17 ms
873fb42 352.10 ms 397.43 ms 45.33 ms
3334ac1 303.98 ms 366.65 ms 62.67 ms
5f443de 412.30 ms 491.67 ms 79.37 ms
d089990 361.67 ms 442.50 ms 80.83 ms
0118295 365.71 ms 438.56 ms 72.85 ms
4d763a5 441.22 ms 501.40 ms 60.18 ms
deaeece 347.42 ms 381.10 ms 33.68 ms
d8519f9 352.83 ms 420.46 ms 67.62 ms

App size

Revision Plain With Sentry Diff
fe4aa56 6.06 MiB 7.10 MiB 1.04 MiB
d53c6fa 6.16 MiB 7.14 MiB 1011.18 KiB
873fb42 5.94 MiB 6.96 MiB 1.02 MiB
3334ac1 6.06 MiB 7.03 MiB 993.54 KiB
5f443de 6.35 MiB 7.34 MiB 1008.00 KiB
d089990 6.34 MiB 7.28 MiB 967.79 KiB
0118295 6.33 MiB 7.26 MiB 947.07 KiB
4d763a5 6.49 MiB 7.57 MiB 1.08 MiB
deaeece 5.94 MiB 6.96 MiB 1.02 MiB
d8519f9 6.33 MiB 7.26 MiB 946.13 KiB

Previous results on branch: enhancement/cache-parsed-dsn

Startup times

Revision Plain With Sentry Diff
d92de3f 437.35 ms 497.63 ms 60.28 ms

App size

Revision Plain With Sentry Diff
d92de3f 6.49 MiB 7.57 MiB 1.08 MiB

Copy link
Contributor

github-actions bot commented Oct 17, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1259.44 ms 1291.90 ms 32.46 ms
Size 8.38 MiB 9.75 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c70e01a 1273.00 ms 1299.12 ms 26.12 ms
f770c4c 1204.61 ms 1222.82 ms 18.20 ms
98d9a4a 1244.73 ms 1266.33 ms 21.59 ms
30c1193 1227.20 ms 1235.00 ms 7.80 ms
7ec9238 1259.69 ms 1281.59 ms 21.90 ms
24f71aa 1267.47 ms 1272.00 ms 4.53 ms
636cb61 1266.06 ms 1271.38 ms 5.31 ms
6e083bb 1244.33 ms 1264.60 ms 20.26 ms
ebfead1 1271.57 ms 1284.48 ms 12.91 ms
6034b0a 1244.89 ms 1270.22 ms 25.33 ms

App size

Revision Plain With Sentry Diff
c70e01a 8.16 MiB 9.17 MiB 1.01 MiB
f770c4c 8.32 MiB 9.38 MiB 1.06 MiB
98d9a4a 8.33 MiB 9.62 MiB 1.29 MiB
30c1193 8.28 MiB 9.34 MiB 1.06 MiB
7ec9238 8.34 MiB 9.65 MiB 1.31 MiB
24f71aa 8.10 MiB 9.16 MiB 1.07 MiB
636cb61 8.28 MiB 9.34 MiB 1.06 MiB
6e083bb 8.16 MiB 9.17 MiB 1.01 MiB
ebfead1 8.10 MiB 9.16 MiB 1.07 MiB
6034b0a 8.33 MiB 9.40 MiB 1.07 MiB

Previous results on branch: enhancement/cache-parsed-dsn

Startup times

Revision Plain With Sentry Diff
d92de3f 1242.51 ms 1274.54 ms 32.03 ms

App size

Revision Plain With Sentry Diff
d92de3f 8.38 MiB 9.75 MiB 1.37 MiB

@buenaflor buenaflor merged commit 8f95e33 into main Oct 22, 2024
137 checks passed
@buenaflor buenaflor deleted the enhancement/cache-parsed-dsn branch October 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache parsed DSN
2 participants