Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webview and video widgets to the sample app #2355

Closed
wants to merge 1 commit into from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 14, 2024

📜 Description

Trying out if we can mask webviews & videos. Because webviews & video components are not part of the flutter core framework (instead, they're separate 3rd party plugins), we cannot checks by widget type. We could, in theory, check the name as a string but that would not work in obfuscated apps and would be counterproductive because then users would see the widgets obfuscated while testing locally (in debug builds) while they would be clearly visible when deployed in release mode (and obfuscated).

Therefore, I'd say we do not obfuscate these by default and let users do so with custom masking introduced by #2324

💡 Motivation and Context

Part of #1193 (comment)

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- add webview and video widgets to the sample app ([#2355](https://github.com/getsentry/sentry-dart/pull/2355))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 49aff5e

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (4d763a5) to head (49aff5e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2355      +/-   ##
==========================================
+ Coverage   84.80%   85.14%   +0.33%     
==========================================
  Files         253       79     -174     
  Lines        9058     2787    -6271     
==========================================
- Hits         7682     2373    -5309     
+ Misses       1376      414     -962     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant