Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: report replay integration #2349

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 14, 2024

📜 Description

add replay integration to events

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Oct 14, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/ios/Classes/SentryFlutterPluginApple.swift

1 similar comment
Copy link
Contributor

github-actions bot commented Oct 14, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/ios/Classes/SentryFlutterPluginApple.swift

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (f3a18f2) to head (13cdd0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
+ Coverage   84.81%   85.17%   +0.35%     
==========================================
  Files         253       79     -174     
  Lines        9054     2785    -6269     
==========================================
- Hits         7679     2372    -5307     
+ Misses       1375      413     -962     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 492.35 ms 528.24 ms 35.89 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7273303 415.33 ms 491.51 ms 76.18 ms
a609134 350.12 ms 404.12 ms 54.00 ms
21d4150 379.31 ms 449.23 ms 69.93 ms
78eeed5 298.35 ms 361.63 ms 63.28 ms
5f443de 412.30 ms 491.67 ms 79.37 ms
50bdfad 395.22 ms 461.21 ms 65.98 ms
9555112 448.81 ms 488.89 ms 40.08 ms
c57d3b7 413.56 ms 508.80 ms 95.24 ms
d783424 302.08 ms 368.10 ms 66.02 ms
d189e01 328.67 ms 397.12 ms 68.45 ms

App size

Revision Plain With Sentry Diff
7273303 6.34 MiB 7.29 MiB 970.36 KiB
a609134 5.94 MiB 6.95 MiB 1.01 MiB
21d4150 5.94 MiB 6.97 MiB 1.03 MiB
78eeed5 6.16 MiB 7.14 MiB 1009.97 KiB
5f443de 6.35 MiB 7.34 MiB 1008.00 KiB
50bdfad 6.33 MiB 7.30 MiB 987.47 KiB
9555112 6.52 MiB 7.59 MiB 1.06 MiB
c57d3b7 6.33 MiB 7.30 MiB 992.08 KiB
d783424 6.16 MiB 7.14 MiB 1007.48 KiB
d189e01 6.16 MiB 7.14 MiB 1009.90 KiB

Previous results on branch: chore/report-replay-integration

Startup times

Revision Plain With Sentry Diff
8ca2ea2 470.22 ms 528.82 ms 58.59 ms

App size

Revision Plain With Sentry Diff
8ca2ea2 6.49 MiB 7.57 MiB 1.08 MiB

Copy link
Contributor

github-actions bot commented Oct 14, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.02 ms 1261.96 ms 14.94 ms
Size 8.38 MiB 9.75 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
333903e 1251.15 ms 1270.21 ms 19.06 ms
d53c6fa 1254.86 ms 1270.83 ms 15.97 ms
b66cc27 1249.64 ms 1275.57 ms 25.94 ms
bf8d36c 1238.33 ms 1258.71 ms 20.38 ms
ffae3e3 1215.82 ms 1238.49 ms 22.67 ms
6fedcab 1242.33 ms 1269.66 ms 27.33 ms
ba9c106 1241.76 ms 1265.15 ms 23.40 ms
bc29768 1247.25 ms 1268.63 ms 21.38 ms
a4c4f8c 1217.77 ms 1245.88 ms 28.11 ms
3e5078c 1239.73 ms 1248.69 ms 8.96 ms

App size

Revision Plain With Sentry Diff
333903e 8.10 MiB 9.16 MiB 1.06 MiB
d53c6fa 8.29 MiB 9.39 MiB 1.10 MiB
b66cc27 8.38 MiB 9.74 MiB 1.36 MiB
bf8d36c 8.38 MiB 9.74 MiB 1.36 MiB
ffae3e3 8.28 MiB 9.33 MiB 1.05 MiB
6fedcab 8.32 MiB 9.50 MiB 1.18 MiB
ba9c106 8.32 MiB 9.38 MiB 1.06 MiB
bc29768 8.32 MiB 9.38 MiB 1.05 MiB
a4c4f8c 8.38 MiB 9.74 MiB 1.36 MiB
3e5078c 8.28 MiB 9.34 MiB 1.06 MiB

Previous results on branch: chore/report-replay-integration

Startup times

Revision Plain With Sentry Diff
8ca2ea2 1243.92 ms 1270.24 ms 26.32 ms

App size

Revision Plain With Sentry Diff
8ca2ea2 8.38 MiB 9.75 MiB 1.37 MiB

Copy link
Contributor

github-actions bot commented Oct 14, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/ios/Classes/SentryFlutterPluginApple.swift

@vaind vaind marked this pull request as ready for review October 14, 2024 12:23
@vaind vaind merged commit 8da6ae0 into main Oct 14, 2024
52 checks passed
@vaind vaind deleted the chore/report-replay-integration branch October 14, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants