Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve app start integration #2266

Merged
merged 25 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e423a36
Change static vars to member vars
denrase Sep 3, 2024
77e1e11
leave integration test for now
denrase Sep 3, 2024
7246d5e
remove completer
denrase Sep 3, 2024
a7fd92d
Move `NativeAppStartEventProcessor` functionality into integration
denrase Sep 9, 2024
17e05e9
Merge branch 'main' into feat/improve-app-start-integration
denrase Sep 9, 2024
0256cc1
fix integration test, call handler with corerct hub & options
denrase Sep 9, 2024
e14455f
cleanup
denrase Sep 9, 2024
c0b7acb
Merge branch 'main' into feat/improve-app-start-integration
denrase Sep 9, 2024
52fcc2b
add cl entry
denrase Sep 9, 2024
f8e4ca3
remove unused getter
denrase Sep 9, 2024
39592de
Merge branch 'main' into feat/improve-app-start-integration
denrase Sep 10, 2024
227ffa9
catch potential errors in native app start integration
denrase Sep 10, 2024
a3211e6
correclty support appStart and and deprecate it
denrase Sep 10, 2024
6ae5a65
make helper classes private to file
denrase Sep 10, 2024
24d43f6
remove unused methods
denrase Sep 10, 2024
461d207
cleanup
denrase Sep 11, 2024
affdf87
Fix blockng ui issue
denrase Sep 11, 2024
43c4960
don’t create duplicate root transaction in sentry navigator observer
denrase Sep 11, 2024
8f58f3c
fix analyzer issue
denrase Sep 11, 2024
3f1ea18
remove useless method call
denrase Sep 11, 2024
9e7c614
revert deprecation of SentryFlutter.setAppStartEnd
denrase Sep 11, 2024
d04a57c
amend changelog
denrase Sep 11, 2024
7a36c90
Merge branch 'main' into feat/improve-app-start-integration
buenaflor Sep 16, 2024
d58258e
Merge branch 'main' into feat/improve-app-start-integration
denrase Sep 17, 2024
02ce10e
use final in loop
denrase Sep 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Unreleased

### Enhancements

- Improve app start integration ([#2266](https://github.com/getsentry/sentry-dart/pull/2266))
denrase marked this conversation as resolved.
Show resolved Hide resolved
- Fixes ([#2103](https://github.com/getsentry/sentry-dart/issues/2103))
- Fixes ([#2233](https://github.com/getsentry/sentry-dart/issues/2233))

## 8.9.0

### Features
Expand Down
3 changes: 0 additions & 3 deletions flutter/example/integration_test/integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart';
import 'package:sentry_flutter/sentry_flutter.dart';
import 'package:sentry_flutter/src/integrations/native_app_start_integration.dart';
import 'package:sentry_flutter_example/main.dart';

void main() {
Expand All @@ -26,8 +25,6 @@ void main() {
// Using fake DSN for testing purposes.
Future<void> setupSentryAndApp(WidgetTester tester,
{String? dsn, BeforeSendCallback? beforeSendCallback}) async {
NativeAppStartIntegration.isIntegrationTest = true;

await setupSentry(
() async {
await tester.pumpWidget(SentryScreenshotWidget(
Expand Down
2 changes: 1 addition & 1 deletion flutter/example/ios/Runner/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import UIKit
import Flutter
import Sentry

@UIApplicationMain
@main
@objc class AppDelegate: FlutterAppDelegate {
private let _channel = "example.flutter.sentry.io"

Expand Down
2 changes: 1 addition & 1 deletion flutter/example/lib/user_feedback_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class _SentryLogo extends StatelessWidget {
var color = Colors.white;
final brightenss = Theme.of(context).brightness;
if (brightenss == Brightness.light) {
color = const Color(0xff362d59).withOpacity(1.0);
color = const Color(0xff362d59);
}

return FittedBox(
Expand Down

This file was deleted.

Loading
Loading