Record dropped spans in client reports #2154

buenaflor · 2024-07-09T14:41:14Z

📜 Description

Reports the dropped spans as well in client reports, not only the transaction

For all platforms this change reports dropped spans through:

sampling
beforeSend/beforeSendTransaction -> either dropping the whole transaction or keeping the transaction but only dropping a few spans
event processors with same report behaviour as beforeSend

For Web, Linux, Windows (through HttpTransport):

rate limiter
network errors

rate limit or network errors on ios, macos or android are handled by the native sdks

💡 Motivation and Context

Related #2137

💚 How did you test it?

Unit tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2024-07-09T14:41:59Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 03a297d

codecov · 2024-07-09T14:43:32Z

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.34%. Comparing base (3d305b9) to head (03a297d).
Report is 2 commits behind head on main.

Files	Patch %	Lines
dart/lib/src/client_reports/discarded_event.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   88.31%   88.34%   +0.03%     
==========================================
  Files         225      226       +1     
  Lines        7778     7816      +38     
==========================================
+ Hits         6869     6905      +36     
- Misses        909      911       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-09T14:55:00Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.60 ms	1239.00 ms	16.40 ms
Size	8.33 MiB	9.63 MiB	1.29 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`31b2afb`	1244.90 ms	1261.37 ms	16.47 ms
`683fd34`	1239.83 ms	1259.08 ms	19.25 ms
`b0811cc`	1238.23 ms	1255.82 ms	17.59 ms
`84bc635`	1252.26 ms	1273.96 ms	21.70 ms
`9fe67d5`	1242.33 ms	1268.77 ms	26.44 ms
`40680d3`	1243.22 ms	1257.02 ms	13.80 ms
`f0fcbe1`	1238.08 ms	1243.44 ms	5.36 ms
`eb1a7c1`	1281.25 ms	1295.40 ms	14.15 ms
`9c5aec6`	1266.51 ms	1274.65 ms	8.14 ms
`8776cdf`	1237.64 ms	1246.83 ms	9.20 ms

App size

Revision	Plain	With Sentry	Diff
`31b2afb`	8.33 MiB	9.40 MiB	1.07 MiB
`683fd34`	8.28 MiB	9.34 MiB	1.06 MiB
`b0811cc`	8.32 MiB	9.38 MiB	1.06 MiB
`84bc635`	8.33 MiB	9.40 MiB	1.07 MiB
`9fe67d5`	8.32 MiB	9.50 MiB	1.18 MiB
`40680d3`	8.10 MiB	9.16 MiB	1.07 MiB
`f0fcbe1`	8.29 MiB	9.38 MiB	1.09 MiB
`eb1a7c1`	8.15 MiB	9.13 MiB	1000.10 KiB
`9c5aec6`	8.15 MiB	9.12 MiB	986.23 KiB
`8776cdf`	8.33 MiB	9.40 MiB	1.07 MiB

Previous results on branch: feat/report-dropped-spans

Startup times

Revision	Plain	With Sentry	Diff
`783e595`	1227.40 ms	1250.12 ms	22.72 ms
`d8744bf`	1227.43 ms	1243.02 ms	15.59 ms
`1e0eafe`	1226.29 ms	1252.02 ms	25.73 ms
`8ad162f`	1250.43 ms	1262.22 ms	11.80 ms

App size

Revision	Plain	With Sentry	Diff
`783e595`	8.33 MiB	9.63 MiB	1.29 MiB
`d8744bf`	8.33 MiB	9.63 MiB	1.29 MiB
`1e0eafe`	8.33 MiB	9.63 MiB	1.29 MiB
`8ad162f`	8.33 MiB	9.63 MiB	1.29 MiB

github-actions · 2024-07-09T17:29:44Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	410.16 ms	481.39 ms	71.22 ms
Size	6.35 MiB	7.35 MiB	1021.52 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c1bb00f`	303.77 ms	371.88 ms	68.11 ms
`62de927`	313.81 ms	358.15 ms	44.34 ms
`7748b7c`	356.37 ms	426.70 ms	70.33 ms
`1cdcacf`	389.94 ms	463.53 ms	73.59 ms
`6325c3b`	339.33 ms	409.86 ms	70.53 ms
`f6f3d25`	349.44 ms	438.90 ms	89.46 ms
`b728df4`	390.98 ms	445.81 ms	54.83 ms
`ed2ae08`	360.06 ms	440.92 ms	80.86 ms
`8f88a49`	364.98 ms	413.78 ms	48.80 ms
`636cb61`	366.59 ms	448.14 ms	81.55 ms

App size

Revision	Plain	With Sentry	Diff
`c1bb00f`	6.06 MiB	7.09 MiB	1.03 MiB
`62de927`	6.15 MiB	7.11 MiB	981.78 KiB
`7748b7c`	6.27 MiB	7.20 MiB	959.09 KiB
`1cdcacf`	6.33 MiB	7.26 MiB	949.77 KiB
`6325c3b`	5.94 MiB	6.96 MiB	1.02 MiB
`f6f3d25`	6.27 MiB	7.20 MiB	958.60 KiB
`b728df4`	5.94 MiB	6.95 MiB	1.01 MiB
`ed2ae08`	6.27 MiB	7.20 MiB	958.73 KiB
`8f88a49`	6.34 MiB	7.30 MiB	979.60 KiB
`636cb61`	6.27 MiB	7.20 MiB	959.08 KiB

Previous results on branch: feat/report-dropped-spans

Startup times

Revision	Plain	With Sentry	Diff
`d8744bf`	382.70 ms	465.28 ms	82.58 ms
`783e595`	413.77 ms	508.18 ms	94.41 ms
`1e0eafe`	445.67 ms	490.29 ms	44.62 ms
`8ad162f`	413.70 ms	496.67 ms	82.97 ms

App size

Revision	Plain	With Sentry	Diff
`d8744bf`	6.35 MiB	7.35 MiB	1021.17 KiB
`783e595`	6.35 MiB	7.35 MiB	1021.40 KiB
`1e0eafe`	6.35 MiB	7.35 MiB	1021.42 KiB
`8ad162f`	6.35 MiB	7.35 MiB	1019.05 KiB

buenaflor · 2024-07-10T12:05:40Z

dart/lib/src/sentry_envelope_item.dart

+  /// The original, non-encoded object, used when direct access to the source data is needed.
+  Object? originalObject;


used so we don't have to deserialize the envelope when we want to access the number of spans in a transaction for example

buenaflor · 2024-07-10T16:35:30Z

@stefanosiano hey could you review this one for me since you did the implementation on java/android as well pls 🙏

stefanosiano · 2024-07-10T17:42:45Z

dart/lib/src/sentry_client.dart

@@ -475,7 +495,8 @@ class SentryClient {
        }
      }
      if (processedEvent == null) {
-        _recordLostEvent(event, DiscardReason.eventProcessor);
+        _options.recorder
+            .recordLostEvent(DiscardReason.eventProcessor, _getCategory(event));
        _options.logger(SentryLevel.debug, 'Event was dropped by a processor');
        break;
      }


Can you add the same logic of the beforeSend callback here?
report discarded spans from a processor even if the transaction is not dropped
(note that computation should continue in that case, so no need to break)

stefanosiano

Very good!
Just add the case of dropped span in event processor and you're good to go!

* chore(deps): update Cocoa SDK to v8.30.1 (getsentry#2155) * chore: update flutter/scripts/update-cocoa.sh to 8.30.1 * formatting --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: GIancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Set dart runtime version with parsed `Platform.version` (getsentry#2156) * Parse semver * Move dart version to late and only extract it once during init * Set dartVersion to private and move _extractDartVersion out of init * Record dropped spans in client reports (getsentry#2154) * Record dropped spans * Changelog * Naming * Update CHANGELOG.md * Send dropped event as well for rate limit and network error * Update * Dart analyze * Fix test * Improve comments * improvements * Apply same logic of beforeSend to event processor * Fix test * Formatting * Comments * Rename mock * Fix compatibility with Drift 2.19.0 (getsentry#2162) * Add support for drift 2.19.0 * Update * fix test * Update CHANGELOG * Add ignores * Fix flaky app start tests (getsentry#2157) * chore(deps): update Symbol collector CLI to v1.19.0 (getsentry#2164) Co-authored-by: GitHub <noreply@github.com> * Deprecate `setExtra` (getsentry#2159) * deprecate * update * Update deprecate message * Update CHANGELOG * Formatting and ignore warnings * analyze * deps: update ktlint (getsentry#2166) the new version should automatically resolve outdated comments * ci: validate publish dry runs (getsentry#2161) * draft script for checking publish * draft implementation * comment * trigger ci * Update workflow * Update workflow * Update workflow * Update workflow * revert example{ * Update workflow * Temporarily restrict drift for testing * Update pubspec.yaml * Update pubspec.yaml * Revert * Update analyze.yml * Update event_example.dart * Add flag to disable reporting of view hierarchy identifiers (getsentry#2158) * Add report view hierarchy identifier option * Update docs * Update CHANGELOG * Fix test * Formatting * Update CHANGELOG.md * release: 8.4.0 * Update CHANGELOG * build(deps): bump reactivecircus/android-emulator-runner (getsentry#2171) Bumps [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) from 2.31.0 to 2.32.0. - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases) - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md) - [Commits](ReactiveCircus/android-emulator-runner@77986be...f0d1ed2) --- updated-dependencies: - dependency-name: reactivecircus/android-emulator-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): update Cocoa SDK to v8.31.1 (getsentry#2174) * chore: update flutter/scripts/update-cocoa.sh to 8.31.1 * format generated binding --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Ivan Dlugos <dlugos.ivan@gmail.com> * chore(deps): update Android SDK to v7.12.0 (getsentry#2173) * chore: update flutter/scripts/update-android.sh to 7.12.0 * chore: update AGP and Kotlin --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Ivan Dlugos <dlugos.ivan@gmail.com> Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Fix truncated stacktraces in unhandled errors (getsentry#2152) * Fix stacktrace * Fix stacktrace * Update * Update changelog * Add test cases * formatting * formatting * Fix await * build(deps): bump ruby/setup-ruby from 1.185.0 to 1.187.0 (getsentry#2172) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.185.0 to 1.187.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@3a77c29...161cd54) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * fix analyze issues (getsentry#2177) * Update CHANGELOG.md (getsentry#2178) * Disable sff & frame delay detection on web, linux and windows (getsentry#2182) * disable * chore: update metrics/flutter.properties to 3.22.3 (getsentry#2180) Co-authored-by: GitHub <noreply@github.com> * build(deps): bump gradle/gradle-build-action from 3.4.2 to 3.5.0 (getsentry#2186) Bumps [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/gradle/gradle-build-action/releases) - [Commits](gradle/gradle-build-action@66535aa...ac2d340) --- updated-dependencies: - dependency-name: gradle/gradle-build-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ruby/setup-ruby from 1.187.0 to 1.188.0 (getsentry#2187) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.187.0 to 1.188.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@161cd54...50ba338) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Support `ignoredExceptionsForType` (getsentry#2150) * Set platform in sentry frames for better raw stacktrace representation (getsentry#2193) * add platform to stacktrace * update * Update CHANGELOG * Fix tests * Fix test * release: 8.5.0 * chore(deps): update Cocoa SDK to v8.32.0 (getsentry#2195) * chore: update flutter/scripts/update-cocoa.sh to 8.32.0 * Format --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: GIancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * chore(deps): update Symbol collector CLI to v1.21.0 (getsentry#2196) Co-authored-by: GitHub <noreply@github.com> * Implement error type identifier to mitigate obfuscated Flutter issue titles (getsentry#2170) * try to mitigate runtime type not being obfuscated * fix imports * Remove prints * Update * Update * Update exception_type_identifier.dart * Add caching * Update * split up dart:io and dart:html exceptions * fix analyze * Update CHANGELOG * update * Add more tests * Update docs * Update options docs * remove print * remove CustomException * import with show * try fix test * Update CHANGELOG.md * Update CHANGELOG.md * Fix analyze * try fix test * Update CHANGELOG.md * chore: update flutter/scripts/update-android.sh to 7.12.1 (getsentry#2198) Co-authored-by: GitHub <noreply@github.com> * Deprecate `enableTracing` (getsentry#2199) * Deprecate * Add CHANGELOG * Fix flaky exception identifier test on web (getsentry#2201) * Fix test * build(deps): bump ruby/setup-ruby from 1.188.0 to 1.190.0 (getsentry#2202) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.188.0 to 1.190.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@50ba338...a6e6f86) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * release: 8.6.0 * chore: update flutter/scripts/update-android.sh to 7.13.0 (getsentry#2206) Co-authored-by: GitHub <noreply@github.com> * Add `ignored` discard reason (getsentry#2204) * deps: change updater PR strategy to update on low-risk updates (getsentry#2210) Flutter SDK in metrics and symbol-collector update jobs aren't expected to break so there's little reason to keep old PRs * feat: add span level measurements getsentry#1855 (getsentry#2214) * feat: add span level measurements * add changelog entry * add issue link to changelog * fix: correct changelog * moved the stored measurements from root span to tracer * changed issue number to pr number in changelog * fixed formatting * Update CHANGELOG.md Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> --------- Co-authored-by: Martin <martin@haintz.dev> Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> * feat: add `ignoreTransactions` and ignoreErrors` getsentry#1391 (getsentry#2207) * Add ignoreTransactions and ignoreErrors getsentry#1391 * chore: add changelog entry * move methods from sentry_options to sentry_client and change to private * change discard reason to ignored Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> * change iterable to list * add event recorder to ignoredTransactions * add tests for ignoreTransactions * set ignoreErrors list to empty list a default Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> * change variables to final for ignoreTransaction Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> * change var to final for ignoreErrors and adapt test * Update CHANGELOG.md Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> * Add example for ignoreTransactions and ignoreErrors to changelog * fix: check for empty ignoreError and ignoreTransaction before handling regex * moved ignoreTransactions and ignoreErrors back to unreleased area in CHANGELOG.md * refactored implementation of ignoreErrors and ignoreTransactions and improved test cases * removed unnecessary backslash from tests --------- Co-authored-by: Martin <> Co-authored-by: Martin <martin@haintz.dev> Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> * Deserialize and serialize unknown fields (getsentry#2153) * Add proxy support (getsentry#2192) * chore(deps): update Cocoa SDK to v8.33.0 (getsentry#2223) * chore: update flutter/scripts/update-cocoa.sh to 8.33.0 * Formatting * fix analyze --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: GIancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * release: 8.7.0 * add ignoreRoutes parameter to SentryNavigatorObserver (getsentry#2218) * add ignoreRoutes parameter to SentryNavigatorObserver * add unitTest for ignoreRoutes * add changelog entry for ignoreRoutes in the SentryNaviagtorObserver * add for ignore routes, that not TTID and TTFD spans are created Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * add further tests for ignore routes * fix changelog and move ignoreRoutes to unreleased --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * chore(deps): update Flutter SDK (metrics) to v3.24.0 (getsentry#2229) Co-authored-by: GitHub <noreply@github.com> * chore(deps): update Android SDK to v7.14.0 (getsentry#2228) Co-authored-by: GitHub <noreply@github.com> * test: flutter wasm (getsentry#2231) * test: flutter wasm * temporarily disable failing tests * fixup ci * cleanup * feat: Debouncing of SentryWidgetsBindingObserver.didChangeMetrics. getsentry#400 (getsentry#2232) * feat: add debouncer for SentryWidgetsBindingObserver.didChangeMetrics * adapt tests for debouncing * add changelog entry for debouncer * Update flutter/lib/src/utils/debouncer.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/test/widgets_binding_observer_test.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * add internal to debouncer and add whitespaces to comments --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Provide a way to cause an example native crash from Flutter (getsentry#2239) * add SentryFlutter.nativeCrash() for Android and iOS * add changelog entry * remove unused variable * improved kotlin implementation * fix kotlin analysis warnings * Update CHANGELOG.md Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * fix kotlin linter errors * remove whitespace * add Description for nativeCrash --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * chore(deps): update Cocoa SDK to v8.35.1 (getsentry#2247) * chore: update flutter/scripts/update-cocoa.sh to 8.35.1 * format --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: GIancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * chore: fix cocoa bump changelog (getsentry#2248) * release: 8.8.0 * chore(deps): update Flutter SDK (metrics) to v3.24.1 (getsentry#2245) Co-authored-by: GitHub <noreply@github.com> * chore(deps): update Cocoa SDK to v8.36.0 (getsentry#2252) * chore: update flutter/scripts/update-cocoa.sh to 8.36.0 * update --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: GIancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * chore: update windows code based on latest flutter template with plugin_ffi (getsentry#2243) * allow internet and network state access in the flutter example app (getsentry#2255) * allow internet and network state access in the example app * add changelog * feat: Replay support for mobile (getsentry#2208) * Flutter replay for Android (getsentry#2032) * minor gradle fixes * tmp: local sentry-java build * tmp: use relative path to sentry-java * tmp: local java build patches * replay options * replay recorder * wip: JNI native bindings * use compatible jnigen * add missing gradlew to flutter/android * replay recorder JNI binding code * replay recorder binding jni code * jni 0.6 * wip: android jni replay * replay binding * glue code for jni * chore: update to cocoa 8.24.1-alpha.0 * wip: cocoa integration * wip: ios replay * cleanup * formatting * android fixes * move native setup to the native sdk integration * cleanup & improvements * improve widget filter and implement redact options * fix image scaling * ktlint format * ci fixes * fix tests * add jnigen scripts * use android 7.9.0 alpha.1 * move native init & close to SentryNative * cleanup * add macOS integration link * rollback cocoa changes * remove jni/jnigen * wip: methodchannel based android recorder * callback * linter issues * minor fixes * more fixes * linter issues * cleanup * improve logging * move replay to experimental, same as in other SDKs * improve tree shaking * test: scheduler * support browser test * fix compat with old flutter * cleanup * rename recorder_widget_filter.dart * fixup scheduler test * improve test coverage * pr cleanup * test: widget filter * cleanup * test widget filter visibility * cleanup * always add screenshot widget * recorder test * cleanup * limit recorder test to vm * wip: integration test * cleanup * ktlint format * detekt suppression * ktlint format * improve scheduler stop behavior * wip: error replay mapping * suppress detekt TooGenericExceptionThrown * Update flutter/lib/src/replay/recorder.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/native/java/sentry_native_java.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * improve comments * feat: associate dart errors with replays (getsentry#2070) * feat: associate dart errors with replays * ktlint * cleanup * tests * chote: remove path dependency * fix tests * feat: replay breadcrumbs (android) (getsentry#2163) * feat: replay breadcrumbs * ktlint format * fixup tests * cleanup * linter issues * detekt linter issue * move touch path build to dart to deduplicate * fix metrics app compilation * linter issue * test: native replay integration binding (getsentry#2189) * wip: test native integration * test: native replay binding * update example * chore: update pubspec * fixup tests * Update flutter/test/mocks.dart * chore: update changelog * fix publishing * release: 8.6.0-alpha.2 --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: getsentry-bot <bot@getsentry.com> * fix: update android calls after SDK update (getsentry#2211) * fix: update android calls after SDK update * ktlint * feat: iOS replay support (getsentry#2209) * minor gradle fixes * tmp: local sentry-java build * tmp: use relative path to sentry-java * tmp: local java build patches * replay options * replay recorder * wip: JNI native bindings * use compatible jnigen * add missing gradlew to flutter/android * replay recorder JNI binding code * replay recorder binding jni code * jni 0.6 * wip: android jni replay * replay binding * glue code for jni * chore: update to cocoa 8.24.1-alpha.0 * wip: cocoa integration * wip: ios replay * cleanup * formatting * android fixes * move native setup to the native sdk integration * cleanup & improvements * improve widget filter and implement redact options * fix image scaling * ktlint format * ci fixes * fix tests * add jnigen scripts * use android 7.9.0 alpha.1 * move native init & close to SentryNative * cleanup * add macOS integration link * rollback cocoa changes * remove jni/jnigen * wip: methodchannel based android recorder * callback * linter issues * minor fixes * more fixes * linter issues * cleanup * improve logging * move replay to experimental, same as in other SDKs * improve tree shaking * test: scheduler * support browser test * fix compat with old flutter * cleanup * rename recorder_widget_filter.dart * fixup scheduler test * improve test coverage * pr cleanup * test: widget filter * cleanup * test widget filter visibility * cleanup * always add screenshot widget * recorder test * cleanup * limit recorder test to vm * wip: integration test * cleanup * ktlint format * detekt suppression * ktlint format * improve scheduler stop behavior * wip: error replay mapping * suppress detekt TooGenericExceptionThrown * Update flutter/lib/src/replay/recorder.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/native/java/sentry_native_java.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * improve comments * feat: associate dart errors with replays (getsentry#2070) * feat: associate dart errors with replays * ktlint * cleanup * tests * chote: remove path dependency * wip: ios replay * fix result callback * iOS related refactorings * logs * fix tests * call captureReplay on iOS & set * ios replay breadcrumbs * feat: replay breadcrumbs (android) (getsentry#2163) * feat: replay breadcrumbs * ktlint format * fixup tests * cleanup * linter issues * detekt linter issue * move touch path build to dart to deduplicate * fix metrics app compilation * linter issue * test: native replay integration binding (getsentry#2189) * wip: test native integration * test: native replay binding * update example * chore: update pubspec * fixup tests * Update flutter/test/mocks.dart * chore: update changelog * fix publishing * release: 8.6.0-alpha.2 * cleanup * fix macos compilation * test: iOS support * linter issues * linter issues * chore: update changelog * Update flutter/lib/src/native/cocoa/sentry_native_cocoa.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: getsentry-bot <bot@getsentry.com> * fix: cocoa sdk renamed errorSampleRate to onErrorSampleRate * fixup changelog * release: 8.8.0-alpha.1 * chore: update changelog * update changelog --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: getsentry-bot <bot@getsentry.com> * chore: fixup changelog (getsentry#2260) * refactor: Remove workaround for Spotlight image handling (getsentry#2253) * fix: capture replay call on iOS (getsentry#2264) * Support allowUrls, denyUrls (getsentry#2227) * moved regex matcher into regex utils * add allowUrls, denyUrls for web * add changelog entry for allowUrls and denyUrls * add conditional import for non web platforms * fix multiplatform build * fix wording in sentry options * Update dart/lib/src/utils/regex_utils.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * add tests for isMatchingRegexPattern * simplified allowUrls and denyUrls handling * moved allowUrls and denyUrls from dart to flutter * add event processor for html * rephrased documentation and split up tests for web and mobile platform. * add expected error * Update scripts/publish_validation/bin/publish_validation.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/event_processor/url_filter/html_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/event_processor/url_filter/web_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Only access renderObject if `hasSize` is true (getsentry#2263) * feat: asset images don't need to be obscured in replay (getsentry#2269) * feat: asset images don't need to be obscured * chore: update changelog * feat: improve obscure rectangle fit/size (getsentry#2236) * chore(deps): update Flutter SDK (metrics) to v3.24.2 (getsentry#2272) Co-authored-by: GitHub <noreply@github.com> * Fix: Support allowUrls, denyUrls (getsentry#2271) * moved regex matcher into regex utils * add allowUrls, denyUrls for web * add changelog entry for allowUrls and denyUrls * add conditional import for non web platforms * fix multiplatform build * fix wording in sentry options * Update dart/lib/src/utils/regex_utils.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * add tests for isMatchingRegexPattern * simplified allowUrls and denyUrls handling * moved allowUrls and denyUrls from dart to flutter * add event processor for html * rephrased documentation and split up tests for web and mobile platform. * add expected error * Update scripts/publish_validation/bin/publish_validation.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/event_processor/url_filter/html_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/event_processor/url_filter/web_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * modified code to go through stacktrace frames * change matching to window.location --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks (getsentry#2256) * add symbolication * update implementation * update * update * update * update * update * update comment * update * update * update * fix * update * fix tests * fix initial value test * Update comment and test * update * Update NeedsSymbolication * revert sample * revert * update * update naming * update naming and comments of flag * set stacktrace in hint * update * add changelog * update * fix test * fix test * cache debug image * updaet * update var name * updaet * update naming * improve names * break early safeguard for parsing stacktrace and dont throw in hex format parsing * revert load native image list integration * update * fix analyze * fix analyze * feat: capture touch breadcrumbs for all buttons (getsentry#2242) * chore: cleanup user interaction widget code * renames & more cleanup * more cleanup * more refactoring & clenaup before actual functional changes * more refactoring * feat: collect touch element path * update tests * add tests for the new support of non-keyed button presses * cleanup & improve existing code * chore: update changelog * update native replay integration with touch breadcrumb path * fix tests * Update CHANGELOG.md * linter issues --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * fix: repost replay screenshots on android while idle (getsentry#2275) * fix: repost replay screenshots on android while idle * chore: changelog * review change * chore: rename errorSampleRate to onErrorSampleRate (getsentry#2270) * chore: rename errorSampleRate to onErrorSampleRate * Update CHANGELOG.md * release: 8.9.0 * Update CHANGELOG.md * build(deps): bump natiginfo/action-detekt-all from 1.23.6 to 1.23.7 (getsentry#2278) Bumps [natiginfo/action-detekt-all](https://github.com/natiginfo/action-detekt-all) from 1.23.6 to 1.23.7. - [Release notes](https://github.com/natiginfo/action-detekt-all/releases) - [Commits](natiginfo/action-detekt-all@b9daaf5...6bf4342) --- updated-dependencies: - dependency-name: natiginfo/action-detekt-all dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ruby/setup-ruby from 1.190.0 to 1.191.0 (getsentry#2279) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.190.0 to 1.191.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@a6e6f86...52753b7) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Fix typo (getsentry#2283) Fixes a small typo I stumbled upon when reading through the changelogs. #skip-changelog * chore(deps): update Flutter SDK (metrics) to v3.24.3 (getsentry#2287) Co-authored-by: GitHub <noreply@github.com> * fix: event processor failed to stop processing (getsentry#2289) * test: rethrow exceptions (getsentry#2290) * test: rethrow in native SDK integration * test: rethrow in automated test mode * fix event processor runner * test: use options.automatedTestMode everywhere * update failing tests * fix tests * formatting * fix tests * fix: tests * fix tests * update comments * Improve app start integration (getsentry#2266) * build(deps): bump ruby/setup-ruby from 1.191.0 to 1.192.0 (getsentry#2292) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.191.0 to 1.192.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@52753b7...a6b46b8) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update CODEOWNERS (getsentry#2300) * block app start if appLaunchedInForeground is not set. (getsentry#2291) * block app start if appLaunchedInForeground is not set. * add changelog entry * call public method * fix deprecated toUpperCase to uppercase * Update flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * add 60 second timeout for app starts for android native * fix missing time imports * rearrange line * add comma --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * add missing file * rename deprecated method to avoid conflict if the method still available * add deleted file * merge with main * rename deprecated method to avoid conflict if the method still available * adde missing import --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: GIancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: getsentry-bot <bot@getsentry.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Dlugos <dlugos.ivan@gmail.com> Co-authored-by: Denis Andrašec <denrase@gmail.com> Co-authored-by: Martin Haintz <martin.haintz@gmail.com> Co-authored-by: Martin <martin@haintz.dev> Co-authored-by: Giancarlo Buenaflor <giancarlobuenaflor97@gmail.com> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>

Record dropped spans

6eb6dbe

buenaflor changed the title ~~Record dropped spans in client reports~~ Record dropped spans in client reports for Web, Linux and Windows Jul 9, 2024

Changelog

ab8e9ea

buenaflor mentioned this pull request Jul 9, 2024

Report dropped spans in client reports #2137

Closed

Naming

8ad162f

buenaflor marked this pull request as ready for review July 9, 2024 17:28

buenaflor requested review from krystofwoldrich and stefanosiano as code owners July 9, 2024 17:28

Merge branch 'main' into feat/report-dropped-spans

d8744bf

buenaflor changed the title ~~Record dropped spans in client reports for Web, Linux and Windows~~ Record dropped spans in client reports Jul 10, 2024

buenaflor added 7 commits July 10, 2024 08:17

Update CHANGELOG.md

dccede3

Send dropped event as well for rate limit and network error

1e0eafe

Update

dc50f69

Dart analyze

747ee85

Fix test

077c21b

Improve comments

d275793

improvements

783e595

buenaflor commented Jul 10, 2024

View reviewed changes

buenaflor requested a review from cleptric July 10, 2024 16:43

stefanosiano reviewed Jul 10, 2024

View reviewed changes

stefanosiano approved these changes Jul 10, 2024

View reviewed changes

buenaflor added 4 commits July 10, 2024 20:21

Apply same logic of beforeSend to event processor

701e56f

Fix test

4a4d2df

Formatting

8364dac

Comments

fddfed4

Rename mock

03a297d

buenaflor merged commit dd933d4 into main Jul 11, 2024
133 checks passed

buenaflor deleted the feat/report-dropped-spans branch July 11, 2024 11:04

vaind mentioned this pull request Sep 13, 2024

fix: event processor failed to stop processing #2289

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Record dropped spans in client reports #2154

Record dropped spans in client reports #2154

buenaflor commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

codecov bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/report-dropped-spans

Startup times

App size

github-actions bot commented Jul 9, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/report-dropped-spans

Startup times

App size

buenaflor Jul 10, 2024 •

edited

Loading

buenaflor commented Jul 10, 2024 •

edited

Loading

stefanosiano Jul 10, 2024

stefanosiano left a comment

		/// The original, non-encoded object, used when direct access to the source data is needed.
		Object? originalObject;

Record dropped spans in client reports #2154

Record dropped spans in client reports #2154

Conversation

buenaflor commented Jul 9, 2024 • edited Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Jul 9, 2024 • edited Loading

codecov bot commented Jul 9, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 9, 2024 • edited Loading

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/report-dropped-spans

Startup times

App size

github-actions bot commented Jul 9, 2024 • edited Loading

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/report-dropped-spans

Startup times

App size

buenaflor Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

buenaflor commented Jul 10, 2024 • edited Loading

stefanosiano Jul 10, 2024

Choose a reason for hiding this comment

stefanosiano left a comment

Choose a reason for hiding this comment

buenaflor commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

codecov bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

buenaflor Jul 10, 2024 •

edited

Loading

buenaflor commented Jul 10, 2024 •

edited

Loading