Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log warning if both tracesSampleRate and tracesSampler are set #1701

Merged
merged 5 commits into from
Oct 27, 2023
Merged

chore: log warning if both tracesSampleRate and tracesSampler are set #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b15944e
Log warning if both tracesSampleRate and tracesSampler are set
buenaflor Oct 25, 2023
552a6ef
Update CHANGELOG
buenaflor Oct 25, 2023
65e5d1a
Update log
buenaflor Oct 27, 2023
0b4e7f7
Merge branch 'main' into chore/notify-user-trace-settings
buenaflor Oct 27, 2023
65d80de
Update CHANGELOG
buenaflor Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Enhancements

- Log warning if both tracesSampleRate and tracesSampler are set ([#1701](https://github.com/getsentry/sentry-dart/pull/1701))

### Features

- Initial (alpha) support for profiling on iOS and macOS ([#1611](https://github.com/getsentry/sentry-dart/pull/1611))
Expand Down
7 changes: 6 additions & 1 deletion dart/lib/src/sentry_traces_sampler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@
SentryTracesSampler(
this._options, {
Random? random,
}) : _random = random ?? Random();
}) : _random = random ?? Random() {
if (_options.tracesSampler != null && _options.tracesSampleRate != null) {
_options.logger(SentryLevel.warning,

Check warning on line 19 in dart/lib/src/sentry_traces_sampler.dart

View check run for this annotation

Codecov / codecov/patch

dart/lib/src/sentry_traces_sampler.dart#L19 

Added line #L19 was not covered by tests
'Both tracesSampler and traceSampleRate are set. tracesSampler will take precedence and fallback to traceSampleRate if it returns null.');
}
}

SentryTracesSamplingDecision sample(SentrySamplingContext samplingContext) {
final samplingDecision =
Expand Down