Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align method http span convention #1477

Merged
merged 6 commits into from
May 24, 2023

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented May 24, 2023

📜 Description

method was changed to http.method in http spans

💡 Motivation and Context

We want to align to our convention
Closes #1422

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.56 ⚠️

Comparison is base (43760f9) 90.73% compared to head (069f064) 90.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
- Coverage   90.73%   90.18%   -0.56%     
==========================================
  Files          61      181     +120     
  Lines        2030     5776    +3746     
==========================================
+ Hits         1842     5209    +3367     
- Misses        188      567     +379     
Impacted Files Coverage Δ
dart/lib/src/protocol/sentry_response.dart 82.75% <ø> (ø)
dart/lib/src/http_client/tracing_client.dart 84.00% <100.00%> (ø)
dio/lib/src/sentry_transformer.dart 96.15% <100.00%> (ø)
dio/lib/src/tracing_client_adapter.dart 88.00% <100.00%> (ø)

... and 118 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano marked this pull request as ready for review May 24, 2023 11:09
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 318.24 ms 391.56 ms 73.32 ms
Size 6.15 MiB 7.13 MiB 1000.49 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
691aa3b 370.43 ms 466.28 ms 95.85 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
22ed6cb 326.27 ms 393.00 ms 66.73 ms
457a85b 312.37 ms 376.67 ms 64.31 ms
9928a74 375.26 ms 456.30 ms 81.04 ms
eb1a7c1 332.98 ms 381.55 ms 48.57 ms
0a82a1e 321.02 ms 393.82 ms 72.80 ms
2331d89 352.45 ms 417.34 ms 64.89 ms
ed605cc 317.48 ms 374.24 ms 56.76 ms
6d317ea 303.46 ms 356.06 ms 52.60 ms

App size

Revision Plain With Sentry Diff
691aa3b 5.94 MiB 6.96 MiB 1.02 MiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
22ed6cb 6.06 MiB 7.03 MiB 993.37 KiB
457a85b 6.06 MiB 7.09 MiB 1.03 MiB
9928a74 5.94 MiB 6.96 MiB 1.02 MiB
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
2331d89 5.94 MiB 6.96 MiB 1.02 MiB
ed605cc 6.06 MiB 7.03 MiB 993.53 KiB
6d317ea 5.94 MiB 6.92 MiB 1001.74 KiB

Previous results on branch: fix/align-method-http-span-convention

Startup times

Revision Plain With Sentry Diff
87b9ba1 343.16 ms 379.96 ms 36.79 ms
7f01493 299.93 ms 378.12 ms 78.19 ms

App size

Revision Plain With Sentry Diff
87b9ba1 6.15 MiB 7.13 MiB 1000.49 KiB
7f01493 6.15 MiB 7.13 MiB 999.97 KiB

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.23 ms 1242.00 ms 5.77 ms
Size 8.29 MiB 9.36 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
24f71aa 1267.47 ms 1272.00 ms 4.53 ms
aa950e9 1275.17 ms 1295.33 ms 20.16 ms
519423f 1240.80 ms 1260.88 ms 20.08 ms
f2db4ec 1244.14 ms 1259.79 ms 15.65 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
453e1bc 1294.78 ms 1308.10 ms 13.33 ms
e5b744f 1250.82 ms 1284.46 ms 33.64 ms
fbf42af 1253.76 ms 1269.51 ms 15.76 ms
2331d89 1260.86 ms 1281.24 ms 20.39 ms
a49594a 1284.83 ms 1313.29 ms 28.45 ms

App size

Revision Plain With Sentry Diff
24f71aa 8.10 MiB 9.16 MiB 1.07 MiB
aa950e9 8.16 MiB 9.17 MiB 1.01 MiB
519423f 8.10 MiB 9.16 MiB 1.06 MiB
f2db4ec 8.10 MiB 9.16 MiB 1.07 MiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
453e1bc 8.16 MiB 9.16 MiB 1.00 MiB
e5b744f 8.09 MiB 9.07 MiB 1001.19 KiB
fbf42af 8.16 MiB 9.17 MiB 1.01 MiB
2331d89 8.16 MiB 9.17 MiB 1.01 MiB
a49594a 8.16 MiB 9.16 MiB 1.00 MiB

Previous results on branch: fix/align-method-http-span-convention

Startup times

Revision Plain With Sentry Diff
87b9ba1 1249.73 ms 1258.08 ms 8.35 ms
7f01493 1223.96 ms 1240.29 ms 16.33 ms

App size

Revision Plain With Sentry Diff
87b9ba1 8.29 MiB 9.36 MiB 1.07 MiB
7f01493 8.29 MiB 9.36 MiB 1.07 MiB

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanosiano

@marandaneto marandaneto enabled auto-merge (squash) May 24, 2023 11:38
@marandaneto marandaneto merged commit 86d4841 into main May 24, 2023
@marandaneto marandaneto deleted the fix/align-method-http-span-convention branch May 24, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align http span data to convention
2 participants