Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source attribution to adapted repos #1351

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 22, 2023

📜 Description

#skip-changelog

💡 Motivation and Context

getsentry/team-mobile#96

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Thanks @ueman

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.23 🎉

Comparison is base (519423f) 89.96% compared to head (b2376d4) 90.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
+ Coverage   89.96%   90.20%   +0.23%     
==========================================
  Files         176      159      -17     
  Lines        5563     5084     -479     
==========================================
- Hits         5005     4586     -419     
+ Misses        558      498      -60     
Impacted Files Coverage Δ
file/lib/src/sentry_file.dart 54.47% <ø> (ø)
flutter/lib/src/jvm/jvm_exception.dart 100.00% <ø> (ø)
...er_interaction/sentry_user_interaction_widget.dart 95.04% <ø> (ø)
...ter/lib/src/view_hierarchy/sentry_tree_walker.dart 100.00% <ø> (ø)

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ueman
Copy link
Collaborator

ueman commented Mar 22, 2023

You're welcome!

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 283.81 ms 299.53 ms 15.72 ms
Size 6.06 MiB 7.03 MiB 989.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8d64376 302.88 ms 356.84 ms 53.96 ms
6325c3b 339.33 ms 409.86 ms 70.53 ms
3f23617 385.77 ms 476.10 ms 90.33 ms
21d4150 379.31 ms 449.23 ms 69.93 ms
2d3b03d 309.53 ms 353.40 ms 43.87 ms
2331d89 352.45 ms 417.34 ms 64.89 ms
6e083bb 327.96 ms 381.39 ms 53.43 ms
870f5eb 329.45 ms 369.29 ms 39.84 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
aa950e9 337.42 ms 400.72 ms 63.30 ms

App size

Revision Plain With Sentry Diff
8d64376 5.94 MiB 6.96 MiB 1.02 MiB
6325c3b 5.94 MiB 6.96 MiB 1.02 MiB
3f23617 5.94 MiB 6.96 MiB 1.02 MiB
21d4150 5.94 MiB 6.97 MiB 1.03 MiB
2d3b03d 6.06 MiB 7.09 MiB 1.03 MiB
2331d89 5.94 MiB 6.96 MiB 1.02 MiB
6e083bb 5.94 MiB 6.97 MiB 1.03 MiB
870f5eb 5.94 MiB 6.92 MiB 1005.77 KiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
aa950e9 5.94 MiB 6.96 MiB 1.02 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1253.96 ms 1266.12 ms 12.16 ms
Size 8.10 MiB 9.16 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
49a149b 1296.47 ms 1320.20 ms 23.73 ms
1131914 1277.20 ms 1300.20 ms 23.00 ms
21845e2 1279.37 ms 1298.81 ms 19.45 ms
379d7a8 1267.65 ms 1288.39 ms 20.74 ms
08a7b4f 1277.10 ms 1303.37 ms 26.27 ms
fe4aa56 1248.82 ms 1261.35 ms 12.53 ms
6957bfd 1283.80 ms 1289.00 ms 5.20 ms
6d7a391 1265.65 ms 1289.98 ms 24.33 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
0ceb89c 1252.02 ms 1271.78 ms 19.75 ms

App size

Revision Plain With Sentry Diff
49a149b 8.15 MiB 9.12 MiB 986.26 KiB
1131914 8.16 MiB 9.17 MiB 1.01 MiB
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
379d7a8 8.16 MiB 9.16 MiB 1.00 MiB
08a7b4f 8.16 MiB 9.16 MiB 1.01 MiB
fe4aa56 8.10 MiB 9.08 MiB 1004.36 KiB
6957bfd 8.15 MiB 9.15 MiB 1020.71 KiB
6d7a391 8.16 MiB 9.16 MiB 1.01 MiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
0ceb89c 8.15 MiB 9.12 MiB 989.78 KiB

@marandaneto marandaneto merged commit 89ea268 into main Mar 22, 2023
@marandaneto marandaneto deleted the chore/opensource-attribution branch March 22, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants