Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable enableUserInteractionBreadcrumbs on Android when enableAutoNativeBreadcrumbs is disabled #1131

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 14, 2022

📜 Description

💡 Motivation and Context

New feature was added https://docs.sentry.io/platforms/android/enriching-events/breadcrumbs/#disable-automatic-breadcrumbs but not disabled here.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor Author

@krystofwoldrich do we have this flag on RN? if so, we have to fix it as well.

Comment on lines +13 to +15
- Bump Cocoa SDK from v7.30.1 to v7.30.2 ([#1113](https://github.com/getsentry/sentry-dart/pull/1113))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/master/CHANGELOG.md#7302)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/7.30.1...7.30.2)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brustolin you have changed the wrong entry for the changelog, so fixing it here on the fly.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Base: 90.00% // Head: 90.02% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0594f2b) compared to base (a45b9ed).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   90.00%   90.02%   +0.01%     
==========================================
  Files         108      115       +7     
  Lines        3413     3560     +147     
==========================================
+ Hits         3072     3205     +133     
- Misses        341      355      +14     
Impacted Files Coverage Δ
dio/lib/src/breadcrumb_client_adapter.dart 80.00% <0.00%> (ø)
dio/lib/src/failed_request_interceptor.dart 100.00% <0.00%> (ø)
dio/lib/src/sentry_dio_extension.dart 83.33% <0.00%> (ø)
dio/lib/src/sentry_transformer.dart 94.44% <0.00%> (ø)
dio/lib/src/sentry_dio_client_adapter.dart 77.77% <0.00%> (ø)
dio/lib/src/dio_event_processor.dart 96.72% <0.00%> (ø)
dio/lib/src/tracing_client_adapter.dart 85.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 352.77 ms 438.74 ms 85.97 ms
Size 5.94 MiB 6.95 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21845e2 345.08 ms 382.82 ms 37.74 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms
0ceb89c 304.57 ms 357.18 ms 52.61 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
eecbbca 324.37 ms 352.49 ms 28.12 ms
d7758e8 300.12 ms 349.88 ms 49.76 ms
3a69405 334.34 ms 369.19 ms 34.85 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
25e9b59 307.00 ms 348.83 ms 41.83 ms
6957bfd 325.88 ms 380.30 ms 54.43 ms

App size

Revision Plain With Sentry Diff
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
0ceb89c 5.94 MiB 6.95 MiB 1.01 MiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
eecbbca 5.94 MiB 6.89 MiB 975.78 KiB
d7758e8 5.94 MiB 6.95 MiB 1.01 MiB
3a69405 5.94 MiB 6.95 MiB 1.01 MiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
25e9b59 5.94 MiB 6.95 MiB 1.01 MiB
6957bfd 5.94 MiB 6.95 MiB 1.01 MiB

Previous results on branch: fix/disable-enableAutoNativeBreadcrumbs

Startup times

Revision Plain With Sentry Diff
894d871 341.52 ms 421.78 ms 80.25 ms

App size

Revision Plain With Sentry Diff
894d871 5.94 MiB 6.95 MiB 1.01 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1277.71 ms 1287.56 ms 9.85 ms
Size 8.16 MiB 9.15 MiB 1021.81 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3a69405 1292.84 ms 1303.96 ms 11.12 ms
72dfc83 1262.50 ms 1289.75 ms 27.25 ms
5603ab2 1268.47 ms 1280.73 ms 12.26 ms
9c5aec6 1266.51 ms 1274.65 ms 8.14 ms
3e9fb0e 1262.49 ms 1280.65 ms 18.16 ms
b728df4 1287.43 ms 1293.94 ms 6.51 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
abcdba3 1257.31 ms 1283.49 ms 26.18 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms
04db237 1273.29 ms 1306.50 ms 33.21 ms

App size

Revision Plain With Sentry Diff
3a69405 8.15 MiB 9.15 MiB 1018.56 KiB
72dfc83 8.15 MiB 9.12 MiB 987.30 KiB
5603ab2 8.15 MiB 9.12 MiB 990.57 KiB
9c5aec6 8.15 MiB 9.12 MiB 986.23 KiB
3e9fb0e 8.15 MiB 9.12 MiB 989.77 KiB
b728df4 8.15 MiB 9.15 MiB 1020.72 KiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
abcdba3 8.15 MiB 9.12 MiB 989.76 KiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB
04db237 8.15 MiB 9.13 MiB 1003.16 KiB

@marandaneto marandaneto enabled auto-merge (squash) November 14, 2022 10:12
@marandaneto marandaneto merged commit 48e79fd into main Nov 14, 2022
@marandaneto marandaneto deleted the fix/disable-enableAutoNativeBreadcrumbs branch November 14, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants