Skip to content

Commit

Permalink
minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
vaind committed Oct 30, 2023
1 parent 5edbf3d commit 0d8652b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ void main(List<String> arguments) async {
!argVersion.contains('*') &&
argVersion.split('.').length == 3) {
Logger.root.info('Running for a single flutter version: $argVersion');
await processFlutterVerion(FlutterVersion(argVersion));
await processFlutterVersion(FlutterVersion(argVersion));
} else {
// Otherwise, walk all the versions and run for the matching ones.
final versionRegex = RegExp(argVersion.isEmpty
Expand All @@ -48,12 +48,12 @@ void main(List<String> arguments) async {
Logger.root.info(
'Found ${versions.length} Flutter versions matching $versionRegex');
for (var version in versions) {
await processFlutterVerion(version);
await processFlutterVersion(version);
}
}
}

Future<void> processFlutterVerion(FlutterVersion version) async {
Future<void> processFlutterVersion(FlutterVersion version) async {
if (bool.hasEnvironment('CI')) {
print('::group::Processing Flutter ${version.tagName}');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ class SymbolCollectorCli {

void _ensureIsExecutable() {
if (!_isExecutable) {
_isExecutable = true;
if (LocalPlatform().operatingSystem == platform.operatingSystem) {
if (platform.isLinux || platform.isMacOS) {
_log.fine('Making Symbol-collector CLI executable (chmod +x)');

posix.chmod(cli, '0700');
}
_isExecutable = true;
} else {
_log.warning(
'Symbol-collector CLI has been run with a platform that is not the current OS platform.'
Expand Down

0 comments on commit 0d8652b

Please sign in to comment.