Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 1, 2025

I just noticed that this class had a strange pattern of logging errors when used without UIKit instead of using the macros we had defined. Updated it so it wouldn't accidentally get used, luckily it looks like there isn't a call site using it when it shouldn't

#skip-changelog

Closes #6313

Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.724%. Comparing base (5b469c0) to head (e6daf0b).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryScreenFrames.m 0.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6312       +/-   ##
=============================================
- Coverage   86.824%   86.724%   -0.101%     
=============================================
  Files          438       432        -6     
  Lines        37328     36994      -334     
  Branches     17438     15652     -1786     
=============================================
- Hits         32410     32083      -327     
+ Misses        4875      4871        -4     
+ Partials        43        40        -3     
Files with missing lines Coverage Δ
Sources/Sentry/SentryScreenFrames.m 76.923% <0.000%> (+0.732%) ⬆️

... and 60 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b469c0...e6daf0b. Read the comment docs.

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am converting this to swift in here: #6094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Cleanup interface for SentryScreenFrames without UIKit
2 participants