fix(profiling): add ui tests for new launch profiling modes #5008
+198
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/profiling/new-continuous-apis/8-function-renames #5008 +/- ##
==================================================================================================
+ Coverage 8.906% 92.571% +83.665%
==================================================================================================
Files 358 673 +315
Lines 25668 82942 +57274
Branches 94 30042 +29948
==================================================================================================
+ Hits 2286 76781 +74495
+ Misses 23382 6066 -17316
- Partials 0 95 +95
... and 658 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d974391 | 1241.08 ms | 1258.67 ms | 17.59 ms |
| 006c78d | 1226.40 ms | 1241.45 ms | 15.05 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d974391 | 22.30 KiB | 843.77 KiB | 821.47 KiB |
| 006c78d | 22.30 KiB | 843.78 KiB | 821.48 KiB |
Previous results on branch: armcknight/profiling/new-continuous-apis/9-launch-profile-ui-tests
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34a8741 | 1222.45 ms | 1230.63 ms | 8.18 ms |
| 0eb5b93 | 1218.73 ms | 1245.35 ms | 26.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34a8741 | 22.30 KiB | 844.48 KiB | 822.18 KiB |
| 0eb5b93 | 22.30 KiB | 844.49 KiB | 822.18 KiB |
…ogic in some places
armcknight
force-pushed
the
armcknight/profiling/new-continuous-apis/8-function-renames
branch
from
80190da to
b6da0a4
Compare
armcknight
force-pushed
the
armcknight/profiling/new-continuous-apis/9-launch-profile-ui-tests
branch
from
3b90a13 to
43fd159
Compare
philipphofmann
approved these changes
Mar 21, 2025
Comment on lines
+292
to
+298
| # if SENTRY_TEST || SENTRY_TESTCI | ||
| SENTRY_CASSERT( | ||
| NO, @"Expected a continuous profiler to be running for this configuration."); | ||
| # else | ||
| SENTRY_LOG_WARN( | ||
| @"Expected a continuous profiler to be running for this configuration."); | ||
| # endif // SENTRY_TEST || SENTRY_TESTCI |
There was a problem hiding this comment.
l: Maybe we could define a macro that calls SENTRY_CASSERT when SENTRY_TEST || SENTRY_TESTCI and calls SENTRY_LOG_WARN otherwise to reduce some duplication.
Comment on lines
+113
to
+114
| case SentryProfilerTruncationReasonPanic: | ||
| return @"panic"; |
There was a problem hiding this comment.
m: It would be great to have a test for this.
Comment on lines
+708
to
+713
| - (BOOL)isProfilingCorrelatedToTraces | ||
| { | ||
| return ![self isContinuousProfilingEnabled] | ||
| || _profiling.lifecycle == SentryProfileLifecycleTrace; | ||
| } | ||
|
|
There was a problem hiding this comment.
m: It would be great to have some unit tests for this logic.
…ames' into armcknight/profiling/new-continuous-apis/9-launch-profile-ui-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with some small fixes needed in logic
also converted more bare asserts to warnings in production with early exits where needed.
#skip-changelog; for #4853