fix(profiling): reevaluate sample rate on fg with new API

[armcknight]

I'd misinterpreted one of the specs for when the session sample rate would be evaluated, thinking it was only on calls to SentrySDK.startWithOptions, but it also is reevaluated when the app is brought back to the foreground after a bg.

#skip-changelog; for #4853

[codecov]

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.726%. Comparing base (6590f84) to head (6291921).
Report is 2 commits behind head on armcknight/git-chain/profiling/new-continuous-apis/0-topic-branch.

Files with missing lines	Patch %	Lines
...ntegrations/Performance/SentryProfileOptions.swift	70.000%	3 Missing ⚠️

Additional details and impacted files

@@                                           Coverage Diff                                           @@
##           armcknight/git-chain/profiling/new-continuous-apis/0-topic-branch     #4997       +/-   ##
=======================================================================================================
+ Coverage                                                             92.631%   92.726%   +0.094%     
=======================================================================================================
  Files                                                                    673       673               
  Lines                                                                  82661     82680       +19     
  Branches                                                               28967     30020     +1053     
=======================================================================================================
+ Hits                                                                   76570     76666       +96     
+ Misses                                                                  5995      5916       -79     
- Partials                                                                  96        98        +2     

Files with missing lines	Coverage Δ
...urces/Sentry/Profiling/SentryContinuousProfiler.mm	91.176% <100.000%> (+1.176%)	⬆️
Sources/Sentry/Profiling/SentryTraceProfiler.mm	95.522% <ø> (ø)
Sources/Sentry/SentryProfiler.mm	89.516% <100.000%> (+0.259%)	⬆️
Sources/Sentry/SentrySampling.m	94.285% <100.000%> (ø)
...ntegrations/Performance/SentryProfileOptions.swift	75.000% <70.000%> (-25.000%)	⬇️

... and 23 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6590f84...6291921. Read the comment docs.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1225.00 ms	1244.76 ms	19.76 ms
Size	22.30 KiB	840.29 KiB	817.98 KiB

Baseline results on branch: armcknight/git-chain/profiling/new-continuous-apis/0-topic-branch

Startup times

Revision	Plain	With Sentry	Diff
11c45fa	1232.76 ms	1252.08 ms	19.32 ms
9667f56	1219.00 ms	1235.13 ms	16.13 ms
781bb09	1230.79 ms	1250.00 ms	19.21 ms
28931ab	1227.59 ms	1245.56 ms	17.97 ms
b87a934	1208.32 ms	1237.02 ms	28.70 ms
b81c36b	1229.65 ms	1252.16 ms	22.51 ms
346d3a3	1215.51 ms	1250.65 ms	35.14 ms
28250fc	1229.90 ms	1249.08 ms	19.18 ms
99dbffb	1229.43 ms	1250.16 ms	20.73 ms
d9789ac	1224.06 ms	1248.47 ms	24.41 ms

App size

Revision	Plain	With Sentry	Diff
11c45fa	22.30 KiB	839.07 KiB	816.77 KiB
9667f56	22.30 KiB	829.36 KiB	807.06 KiB
781bb09	22.30 KiB	833.45 KiB	811.14 KiB
28931ab	22.30 KiB	840.17 KiB	817.86 KiB
b87a934	22.30 KiB	840.16 KiB	817.85 KiB
b81c36b	22.30 KiB	823.44 KiB	801.13 KiB
346d3a3	22.30 KiB	833.56 KiB	811.26 KiB
28250fc	22.30 KiB	829.69 KiB	807.39 KiB
99dbffb	22.30 KiB	840.17 KiB	817.86 KiB
d9789ac	22.30 KiB	823.68 KiB	801.38 KiB

Previous results on branch: armcknight/profiling/new-continuous-apis/reevaluate-sample-rate-on-fg

Startup times

Revision	Plain	With Sentry	Diff
b0669f6	1214.56 ms	1236.65 ms	22.09 ms
bea2645	1225.67 ms	1245.24 ms	19.57 ms

App size

Revision	Plain	With Sentry	Diff
b0669f6	22.30 KiB	840.39 KiB	818.08 KiB
bea2645	22.30 KiB	840.39 KiB	818.08 KiB

[philipphofmann]

Thanks, this approach should work now. LGTM