Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option for uncaught NSExceptions on macOS #4471

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/uncaught-ns-exceptions

304f39a
Select commit
Loading
Failed to load commit list.
Open

feat: Option for uncaught NSExceptions on macOS #4471

Merge branch 'main' into feat/uncaught-ns-exceptions
304f39a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 24, 2024 in 0s

91.790% (-0.029%) compared to 4569cc9

View this Pull Request on Codecov

91.790% (-0.029%) compared to 4569cc9

Details

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 91.790%. Comparing base (4569cc9) to head (304f39a).

Files with missing lines Patch % Lines
SentryTestUtils/ClearTestState.swift 0.000% 6 Missing ⚠️
.../SentryCrash/SentryUncaughtNSExceptionsTests.swift 0.000% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4471       +/-   ##
=============================================
- Coverage   91.818%   91.790%   -0.029%     
=============================================
  Files          610       611        +1     
  Lines        68230     68240       +10     
  Branches     24493     24494        +1     
=============================================
- Hits         62648     62638       -10     
- Misses        5489      5510       +21     
+ Partials        93        92        -1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryCrashIntegration.m 99.038% <100.000%> (+0.009%) ⬆️
Sources/Sentry/SentryOptions.m 99.433% <ø> (ø)
...ions/SentryCrash/SentryCrashIntegrationTests.swift 86.850% <ø> (ø)
Tests/SentryTests/SentryOptionsTest.m 98.451% <ø> (ø)
.../SentryCrash/SentryUncaughtNSExceptionsTests.swift 0.000% <0.000%> (ø)
SentryTestUtils/ClearTestState.swift 90.000% <0.000%> (-10.000%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4569cc9...304f39a. Read the comment docs.