-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Start/Stop session replay #4414
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4414 +/- ##
=============================================
+ Coverage 91.293% 91.315% +0.022%
=============================================
Files 610 610
Lines 49616 49696 +80
Branches 17876 17909 +33
=============================================
+ Hits 45296 45380 +84
+ Misses 4229 4224 -5
- Partials 91 92 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be2977c | 1202.51 ms | 1221.32 ms | 18.81 ms |
ec879f7 | 1218.12 ms | 1236.08 ms | 17.96 ms |
7cd187e | 1229.02 ms | 1233.06 ms | 4.04 ms |
5783680 | 1223.63 ms | 1243.60 ms | 19.97 ms |
913fab7 | 1226.24 ms | 1252.94 ms | 26.70 ms |
4d68229 | 1233.50 ms | 1262.92 ms | 29.42 ms |
e9fa2b0 | 1226.22 ms | 1248.47 ms | 22.24 ms |
39b1c35 | 1244.71 ms | 1248.60 ms | 3.89 ms |
ca91a5c | 1234.53 ms | 1249.86 ms | 15.33 ms |
5b3518e | 1242.27 ms | 1257.81 ms | 15.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be2977c | 22.85 KiB | 407.67 KiB | 384.83 KiB |
ec879f7 | 21.58 KiB | 669.68 KiB | 648.10 KiB |
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
5783680 | 21.58 KiB | 714.18 KiB | 692.60 KiB |
913fab7 | 21.58 KiB | 703.60 KiB | 682.02 KiB |
4d68229 | 20.76 KiB | 432.34 KiB | 411.58 KiB |
e9fa2b0 | 21.58 KiB | 629.61 KiB | 608.03 KiB |
39b1c35 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
ca91a5c | 22.84 KiB | 403.19 KiB | 380.34 KiB |
5b3518e | 21.58 KiB | 612.11 KiB | 590.53 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused with the install integration if it's nil approach.
Tests/SentryTests/Integrations/SessionReplay/SentrySessionReplayIntegrationTests.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentrySessionReplay.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
…try-cocoa into feat/SR-Start-Stop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe we miss some tests, but that's not blocking.
Improved Performance for SwiftUI session replay
📜 Description
Added Api to manually control session replay start and stop
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.