-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pause and resume AppHangTracking API #4077
Conversation
Add two methods pauseAppHangTracking and resumeAppHangTracking to ignore reported AppHangs. Fixes GH-3472
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4077 +/- ##
=============================================
- Coverage 91.208% 91.094% -0.114%
=============================================
Files 611 611
Lines 48126 47838 -288
Branches 17288 0 -17288
=============================================
- Hits 43895 43578 -317
- Misses 4138 4260 +122
+ Partials 93 0 -93
... and 88 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0559a8f | 1236.90 ms | 1253.46 ms | 16.56 ms |
dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
e324230 | 1225.84 ms | 1250.40 ms | 24.57 ms |
1734d1b | 1219.41 ms | 1236.84 ms | 17.43 ms |
3277f18 | 1229.29 ms | 1248.92 ms | 19.63 ms |
6e342ac | 1216.02 ms | 1232.88 ms | 16.86 ms |
326b7eb | 1252.86 ms | 1259.56 ms | 6.70 ms |
a71f5e2 | 1239.92 ms | 1250.67 ms | 10.76 ms |
ee3f02e | 1236.53 ms | 1263.54 ms | 27.01 ms |
5f8ee7a | 1249.48 ms | 1252.20 ms | 2.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0559a8f | 21.58 KiB | 419.81 KiB | 398.22 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
e324230 | 22.85 KiB | 408.87 KiB | 386.02 KiB |
1734d1b | 21.58 KiB | 418.82 KiB | 397.23 KiB |
3277f18 | 22.84 KiB | 402.88 KiB | 380.03 KiB |
6e342ac | 20.76 KiB | 436.66 KiB | 415.90 KiB |
326b7eb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
a71f5e2 | 21.58 KiB | 424.34 KiB | 402.76 KiB |
ee3f02e | 22.84 KiB | 401.67 KiB | 378.83 KiB |
5f8ee7a | 22.85 KiB | 411.93 KiB | 389.08 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
A couple of nitpick suggestions.
📜 Description
Add two methods pauseAppHangTracking and
resumeAppHangTracking to ignore reported AppHangs.
Docs PR getsentry/sentry-docs#10409.
💡 Motivation and Context
Fixes GH-3472
💚 How did you test it?
Unit tests and sample app.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps