test: clear test state in any test case using SentryDependencyContainer #3378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at continued flakes of reachability tests, I noticed there are still dangling reachability observer instances when new test cases start (which I believe were coming from SentryHttpTransportTests). When I looked further I noticed that there were several tests that use SentryDependencyContainer, but never clean it up afterwards, so I added that call to each test suite's
tearDown
method.Also changed one tearDown to tearDownWithError that did a manual XCTFail in a do/try/catch.
#skip-changelog