feat: Include unfinished spans in transactions #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #1592 +/- ##
=======================================
Coverage 95.94% 95.95%
=======================================
Files 157 157
Lines 7061 7068 +7
=======================================
+ Hits 6775 6782 +7
Misses 286 286
Continue to review full report at Codecov.
|
Sources/Sentry/SentryTracer.m
Outdated
| if (finishedSpan != self.rootSpan) { | ||
| // calls finish on the rootSpan. If the root span is finished, it alread finished every | ||
| // unfinished child. | ||
| if (finishedSpan != self.rootSpan && !self.rootSpan.isFinished) { |
There was a problem hiding this comment.
m: I think it would be better to avoid the endless loop in canBeFinished not here. So canBeFinished should check if finishedSpan != self.rootSpan.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Instead of removing unfinished spans from the transaction in order to avoid the transaction to be discarded, we close all unfinished spans with
deadline_exceededstatus.💡 Motivation and Context
closes #1303
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps