Skip to content

Commit

Permalink
ref(transport): Log a warning when dropping envelopes due to rate-lim…
Browse files Browse the repository at this point in the history
…iting (#4463)

Log a warning if all items of the current envelope were rate-limited.
  • Loading branch information
rwachtler authored Oct 24, 2024
1 parent 2d0e628 commit 91ad2c7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Improvements

- Log a warning when dropping envelopes due to rate-limiting (#4463)

## 8.39.0-beta.1

### Removal of Experimental API
Expand Down
3 changes: 2 additions & 1 deletion Sources/Sentry/SentryHttpTransport.m
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ - (void)sendEnvelope:(SentryEnvelope *)envelope
envelope = [self.envelopeRateLimit removeRateLimitedItems:envelope];

if (envelope.items.count == 0) {
SENTRY_LOG_DEBUG(@"RateLimit is active for all envelope items.");
SENTRY_LOG_WARN(@"RateLimit is active for all envelope items.");
return;
}

Expand Down Expand Up @@ -232,6 +232,7 @@ - (SentryFlushResult)flush:(NSTimeInterval)timeout
- (void)envelopeItemDropped:(SentryEnvelopeItem *)envelopeItem
withCategory:(SentryDataCategory)dataCategory;
{
SENTRY_LOG_WARN(@"Envelope item dropped due to exceeding rate limit. Category: %@", nameForSentryDataCategory(dataCategory));
[self recordLostEvent:dataCategory reason:kSentryDiscardReasonRateLimitBackoff];
[self recordLostSpans:envelopeItem reason:kSentryDiscardReasonRateLimitBackoff];
}
Expand Down

0 comments on commit 91ad2c7

Please sign in to comment.