test: Add missing test for transaction name (#2900)

getsentry · Apr 14, 2023 · 8c50edb · 8c50edb
1 parent 65b8953
commit 8c50edb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Sources/Sentry/SentryTransaction.m b/Sources/Sentry/SentryTransaction.m
@@ -85,7 +85,7 @@ - (instancetype)initWithTrace:(SentryTracer *)trace children:(NSArray<id<SentryS
     }
 
     if (self.trace) {
-        [serializedData setValue:self.trace.transactionContext.name forKey:@"transaction"];
+        serializedData[@"transaction"] = self.trace.transactionContext.name;
 
         serializedData[@"transaction_info"] =
             @{ @"source" : [self stringForNameSource:self.trace.transactionContext.nameSource] };

diff --git a/Tests/SentryTests/Transaction/SentryTransactionTests.swift b/Tests/SentryTests/Transaction/SentryTransactionTests.swift
@@ -169,4 +169,13 @@ class SentryTransactionTests: XCTestCase {
         let actualTransactionInfo = actual["transaction_info"] as? [String: String]
         XCTAssertEqual(actualTransactionInfo?["source"], "component")
     }
+
+    func testSerialize_TransactionName() {
+        let scope = Scope()
+        let transaction = fixture.getTransactionWith(scope: scope)
+        let actual = transaction.serialize()
+
+        let actualTransaction = actual["transaction"] as? String
+        XCTAssertEqual(actualTransaction, fixture.transactionName)
+    }
 }