Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply Jetpack Compose instrumentation if Modifier class is available #727

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Jul 2, 2024

📜 Description

If the Kotlin Compiler Plugin is applied for non Compose enabled modules, it will cause a crash during app compilation.

💡 Motivation and Context

Fixes #687

💚 How did you test it?

Manually

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@markushi markushi changed the title Fix properly ensure modifier class is available Fix Only apply Jetpack Compose instrumentation if Modifier class is available Jul 2, 2024
@markushi markushi changed the title Fix Only apply Jetpack Compose instrumentation if Modifier class is available Only apply Jetpack Compose instrumentation if Modifier class is available Jul 2, 2024
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@markushi markushi merged commit 9944638 into main Jul 3, 2024
19 checks passed
@markushi markushi deleted the fix/kotlin-compiler-plugin-crash branch July 3, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying io.sentry.kotlin.compiler.gradle on a module with no @Composable functions throws NPE
2 participants