Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Reorganize backup/restore tests for speed and reliability #3537

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Jan 16, 2025

We should do the backup/restore tests after we do the basic tests. This is both more efficient as we avoid an extra up/down cycle and more meaningful as we will back up and restore an actually used system.

A bit hard to measure directly as this also moves the initial docker compose up -w into the test suite but a random run without this patch took about 10m 49s to finish for the testing part whereas with the patch it came down to 9m 10s so almost 2 minutes faster!

We should do the backup/restore tests _after_ we do the basic tests. This is both more efficient as we avoid an extra up/down cycle and more meaningful as we will back up and restore an actually used system.
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (c075cf5) to head (e404036).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3537   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         184      184           
=======================================
  Hits          183      183           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK marked this pull request as ready for review January 16, 2025 14:18
@BYK BYK requested a review from hubertdeng123 January 16, 2025 14:18
@BYK BYK enabled auto-merge (squash) January 16, 2025 14:18
@BYK BYK merged commit 63b6c0a into master Jan 16, 2025
10 checks passed
@BYK BYK deleted the byk/test/optimize-backup-restore branch January 16, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants