-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sentry release for dogfood instance #1768
Merged
hubertdeng123
merged 14 commits into
master
from
hubertdeng123/fix-dogfood-release-tagging
Oct 21, 2022
Merged
Fix sentry release for dogfood instance #1768
hubertdeng123
merged 14 commits into
master
from
hubertdeng123/fix-dogfood-release-tagging
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
commented
Oct 18, 2022
emmatyping
reviewed
Oct 21, 2022
emmatyping
approved these changes
Oct 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses the action-release/v1 to handle releases for dogfood since that's much easier!!
https://github.com/getsentry/action-release
Apparently, the version of the release is set earlier in the prepare release action and set as an environment variable
env.RELEASE_VERSION
so I'm using that. Theignore_missing
andignore_empty
flags are set to avoid erroring out of release script.#1757