This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
feat(contexts): non normalized data set to raw-description #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bruno-garcia
commented
Apr 28, 2018
bruno-garcia
commented
- Leave Name and Version empty if no propert API available to set it
- An SDK consumer with a better system API (i.e: Xamarin) can set Name and Version directly
- Server will use Raw Description if no Name and Version was provided to try normalizing into those 2 fields.
* Leave Name and Version empty if no propert API available to set it * An SDK consumer with a better system API (i.e: Xamarin) can set Name and Version directly * Server will use Raw Description if no Name and Version was provided to try normalizing into those 2 fields.
jan-auer
suggested changes
Apr 30, 2018
| }; | ||
|
|
||
| var actual = JsonConvert.SerializeObject(runtime); | ||
|
|
||
| Assert.That(actual, Is.EqualTo("{\"name\":\"NETCore\",\"version\":\"2.0.1\"}")); | ||
| Assert.That(actual, Is.EqualTo("{\"name\":\"NETCore\",\"version\":\"2.0.1\",\"raw-description\":\"NETCore 2.0.1\"}")); |
There was a problem hiding this comment.
This must be raw_description! Same below.
There was a problem hiding this comment.
thanks for catching that! I updated OS and forgot Runtime
|
@jan-auer could you please check again? |
jan-auer
approved these changes
Apr 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.