Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Commit

Permalink
Make setter of SentryEvent.Tags public
Browse files Browse the repository at this point in the history
To make it easier to include tags directly when constructing a new
`SentryEvent`.

Related to PR #149.
  • Loading branch information
genne committed Sep 14, 2016
1 parent f13de4c commit 7000e25
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/app/SharpRaven/Data/SentryEvent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public SentryMessage Message
public IDictionary<string, string> Tags
{
get { return this.tags; }
internal set { this.tags = value ?? new Dictionary<string, string>(); }
set { this.tags = value ?? new Dictionary<string, string>(); }
}
}
}

3 comments on commit 7000e25

@samukce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, one question. Are there test to assign tags values?
Some like this:

Assert.That(new SentryEvent().Tags, Is.Not.Null);

and

var sentryEvent = new SentryEvent {Tags = null};
 Assert.That(sentryEvent.Tags, Is.Not.Null);

@asbjornu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samukce: Good idea. Happy to receive a PR!

@samukce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#159 done. o/

Please sign in to comment.